Re: [PATCH] misc/vmw_vmci: VMWARE_VMCI depends on NET

Randy Dunlap
2013-04-01T22:53:24Z

On 04/01/13 15:17, Guenter Roeck wrote:
> On Mon, Apr 01, 2013 at 01:11:52PM -0700, Greg Kroah-Hartman wrote:
>> On Mon, Apr 01, 2013 at 01:02:35PM -0700, Guenter Roeck wrote:
>>> On Mon, Apr 01, 2013 at 12:29:39PM -0700, Greg Kroah-Hartman wrote:
>>>> On Sun, Mar 31, 2013 at 09:43:59PM -0700, Guenter Roeck wrote:
>>>>> Fix:
>>>>>
>>>>> ERROR: "memcpy_toiovec" [drivers/misc/vmw_vmci/vmw_vmci.ko] undefined!
>>>>> ERROR: "memcpy_fromiovec" [drivers/misc/vmw_vmci/vmw_vmci.ko] undefined!
>>>>>
>>>>> Both functions are defined in the core networking code.
>>>>
>>>> This is already in linux-next, thanks.
>>>>
>>> Uuh ... and I submitted it. Sorry for the noise.
>>>
>>> Any chance to apply this to 3.9-rc ? It causes a bunch of unnecessary
>>> nightly build errors for me.
>>
>> As it's a configuration that no "real" user would ever hit, it's not
>> really 3.9 material, sorry.
>>
> Fair enough.
>
> On the other side, value of "make randconfig" has been reduced significantly
> compared to earlier times, when patches like this tended to be accepted into
> release candidates. Until a few releases ago, "make randconfig" usually passed
> at least for main targets by the time a kernel was relased. With this no longer
> the case, fewer and fewer people will look into nightly or per-rc build results
> and provide patches. This in turn will likely reduce reliability, as real
> problems are more and more hidden among all the "unreal" build errors.
> In addition to that, more and more people will end up with non-buildable
> configurations and have to spend time trying to figure out why exactly
> a build failed.
>
> But maybe this is all my imagination, so feel free to just ignore my ranting ;).

My experiences have been that Linus is not opposed to taking such
build fixes at almost any time. IOW, I think that Greg is being more
strict than Linus would be, but Greg is the misc/ maintainer, so it's
his call.

--
~Randy