From: Marco Munderloh <munderl@tnt.uni-hannover.de>
To: Ilija Hadzic <ihadzic@research.bell-labs.com>
Cc: Michal Hocko <mhocko@suse.cz>,
Ilija Hadzic <ilijahadzic@gmail.com>,
Thomas Hellstrom <thellstrom@vmware.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm: fix i_mapping and f_mapping initialization in drm_open in error path
Date: Tue, 02 Apr 2013 12:36:00 +0200 [thread overview]
Message-ID: <515AB490.8010703@tnt.uni-hannover.de> (raw)
In-Reply-To: <Pine.GSO.4.64.1304011249370.27674@umail>
[-- Attachment #1: Type: text/plain, Size: 1125 bytes --]
> Attached is a v2 of the patch, for reference. I would appreciate if the original reporter or you tested it in lieu of your proposed patch and let me know if it fixes your
> issue.
The patch works for me. echo 3 > /proc/sys/vm/drop_caches as well as rmmod radeon do not end up in a crash anymore. However, I have still no clue why one of these makes
drm_open to fail. On rmmod radeon I get the following log messages. If don't know if the 'unpin not necessary' has anything to do with it.
[drm] radeon: finishing device.
radeon 0000:01:00.0: ffff88024e526c00 unpin not necessary
radeon 0000:01:00.0: ffff88024f2f6000 unpin not necessary
radeon 0000:01:00.0: ffff88024f2f6000 unpin not necessary
[TTM] Finalizing pool allocator
[TTM] Finalizing DMA pool allocator
[TTM] Zone kernel: Used memory at exit: 0 kiB
[TTM] Zone dma32: Used memory at exit: 0 kiB
[drm] radeon: ttm finalized
vga_switcheroo: disabled
[drm] Module unloaded
By the way, sometimes my r8169 ethernet controller does not survive suspend/hibernation (does not detect link). rmmod/modprobe helps. I don't know if this is related.
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4523 bytes --]
next prev parent reply other threads:[~2013-04-02 10:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-26 19:56 [PATCH] drm: fix i_mapping and f_mapping initialization in drm_open in error path Michal Hocko
2013-03-30 22:26 ` Ilija Hadzic
2013-03-31 10:34 ` Michal Hocko
2013-04-01 18:14 ` Ilija Hadzic
2013-04-02 8:25 ` Michal Hocko
2013-04-02 10:36 ` Marco Munderloh [this message]
[not found] ` <CA+4h6HkOSPUpfT-5Hwe+zRkmSdhURM6Tv4RxM+9PMCEvG+tjZw@mail.gmail.com>
2013-04-02 12:01 ` Marco Munderloh
2013-04-02 13:31 ` Ilija Hadzic
2013-04-02 13:48 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515AB490.8010703@tnt.uni-hannover.de \
--to=munderl@tnt.uni-hannover.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=ihadzic@research.bell-labs.com \
--cc=ilijahadzic@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhocko@suse.cz \
--cc=thellstrom@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox