Re: [PATCH] drm: fix i_mapping and f_mapping initialization in drm_open in error path

[Marco Munderloh <munderl@tnt.uni-hannover.de>]

[-- Attachment #1.1: Type: text/plain, Size: 2039 bytes --]

Hi Ilija,

> Thanks for testing. Other issues are probably unrelated, so I'll send the last version of the patch to Dave.

I came across another problem which seems related. rmmod radeon works, however, modprobe radeon afterwards results in a crash (divide error), see attachment.

Best, Marco

On 02.04.2013 13:23, Ilija Hadzic wrote:
>
> -- Ilija
>
> On Tue, Apr 2, 2013 at 6:36 AM, Marco Munderloh <munderl@tnt.uni-hannover.de <mailto:munderl@tnt.uni-hannover.de>> wrote:
>
>         Attached is a v2 of the patch, for reference. I would appreciate if the original reporter or you tested it in lieu of your proposed patch and let me know if it
>         fixes your
>         issue.
>
>
>     The patch works for me. echo 3 > /proc/sys/vm/drop_caches as well as rmmod radeon do not end up in a crash anymore. However, I have still no clue why one of these makes
>     drm_open to fail. On rmmod radeon I get the following log messages. If don't know if the 'unpin not necessary' has anything to do with it.
>
>     [drm] radeon: finishing device.
>     radeon 0000:01:00.0: ffff88024e526c00 unpin not necessary
>     radeon 0000:01:00.0: ffff88024f2f6000 unpin not necessary
>     radeon 0000:01:00.0: ffff88024f2f6000 unpin not necessary
>     [TTM] Finalizing pool allocator
>     [TTM] Finalizing DMA pool allocator
>     [TTM] Zone  kernel: Used memory at exit: 0 kiB
>     [TTM] Zone   dma32: Used memory at exit: 0 kiB
>     [drm] radeon: ttm finalized
>     vga_switcheroo: disabled
>     [drm] Module unloaded
>
>     By the way, sometimes my r8169 ethernet controller does not survive suspend/hibernation (does not detect link). rmmod/modprobe helps. I don't know if this is related.
>
>

-- 
Dipl.-Ing. Marco Munderloh             Mail: munderl@tnt.uni-hannover.de
Institut für Informationsverarbeitung (TNT)     Phone: +49 511 762-19587
Leibniz Universitaet Hannover, Appelstr. 9a       Fax: +49 511 762- 5333
30167 Hannover, Germany     Web: http://www.tnt.uni-hannover.de/~munderl

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: crash_modprobe_radeon.log --]
[-- Type: text/x-log; name="crash_modprobe_radeon.log", Size: 12139 bytes --]

2013-04-02T12:46:25.434028+02:00 apophis kernel: [ 1826.998301] [drm] radeon defaulting to kernel modesetting.
2013-04-02T12:46:25.434042+02:00 apophis kernel: [ 1826.998303] [drm] radeon kernel modesetting enabled.
2013-04-02T12:46:25.434044+02:00 apophis kernel: [ 1826.998316] VGA switcheroo: detected switching method \_SB_.PCI0.GFX0.ATPX handle
2013-04-02T12:46:25.434045+02:00 apophis kernel: [ 1826.998452] [drm] initializing kernel modesetting (TURKS 0x1002:0x6741 0x104D:0x907B).
2013-04-02T12:46:25.434046+02:00 apophis kernel: [ 1826.998476] [drm] register mmio base: 0xC8400000
2013-04-02T12:46:25.434047+02:00 apophis kernel: [ 1826.998477] [drm] register mmio size: 131072
2013-04-02T12:46:25.434047+02:00 apophis kernel: [ 1826.998478] vga_switcheroo: enabled
2013-04-02T12:46:25.434048+02:00 apophis kernel: [ 1826.998548] ATPX version 1
2013-04-02T12:46:26.290054+02:00 apophis kernel: [ 1827.852872] ATOM BIOS: Sony
2013-04-02T12:46:26.290096+02:00 apophis kernel: [ 1827.852895] radeon 0000:01:00.0: GPU softreset 
2013-04-02T12:46:26.290102+02:00 apophis kernel: [ 1827.852900] radeon 0000:01:00.0:   GRBM_STATUS=0xFFFFFFFF
2013-04-02T12:46:26.290106+02:00 apophis kernel: [ 1827.852905] radeon 0000:01:00.0:   GRBM_STATUS_SE0=0xFFFFFFFF
2013-04-02T12:46:26.290109+02:00 apophis kernel: [ 1827.852909] radeon 0000:01:00.0:   GRBM_STATUS_SE1=0xFFFFFFFF
2013-04-02T12:46:26.290112+02:00 apophis kernel: [ 1827.852914] radeon 0000:01:00.0:   SRBM_STATUS=0xFFFFFFFF
2013-04-02T12:46:26.290115+02:00 apophis kernel: [ 1827.852918] radeon 0000:01:00.0:   R_008674_CP_STALLED_STAT1 = 0xFFFFFFFF
2013-04-02T12:46:26.290118+02:00 apophis kernel: [ 1827.852923] radeon 0000:01:00.0:   R_008678_CP_STALLED_STAT2 = 0xFFFFFFFF
2013-04-02T12:46:26.290121+02:00 apophis kernel: [ 1827.852928] radeon 0000:01:00.0:   R_00867C_CP_BUSY_STAT     = 0xFFFFFFFF
2013-04-02T12:46:26.290124+02:00 apophis kernel: [ 1827.852932] radeon 0000:01:00.0:   R_008680_CP_STAT          = 0xFFFFFFFF
2013-04-02T12:46:27.262050+02:00 apophis kernel: [ 1828.824062] radeon 0000:01:00.0: Wait for MC idle timedout !
2013-04-02T12:46:27.262086+02:00 apophis kernel: [ 1828.824073] radeon 0000:01:00.0:   GRBM_SOFT_RESET=0x00007F6B
2013-04-02T12:46:27.262091+02:00 apophis kernel: [ 1828.824178] radeon 0000:01:00.0:   GRBM_STATUS=0xFFFFFFFF
2013-04-02T12:46:27.262095+02:00 apophis kernel: [ 1828.824182] radeon 0000:01:00.0:   GRBM_STATUS_SE0=0xFFFFFFFF
2013-04-02T12:46:27.262099+02:00 apophis kernel: [ 1828.824186] radeon 0000:01:00.0:   GRBM_STATUS_SE1=0xFFFFFFFF
2013-04-02T12:46:27.262103+02:00 apophis kernel: [ 1828.824191] radeon 0000:01:00.0:   SRBM_STATUS=0xFFFFFFFF
2013-04-02T12:46:27.262106+02:00 apophis kernel: [ 1828.824195] radeon 0000:01:00.0:   R_008674_CP_STALLED_STAT1 = 0xFFFFFFFF
2013-04-02T12:46:27.262109+02:00 apophis kernel: [ 1828.824200] radeon 0000:01:00.0:   R_008678_CP_STALLED_STAT2 = 0xFFFFFFFF
2013-04-02T12:46:27.262112+02:00 apophis kernel: [ 1828.824204] radeon 0000:01:00.0:   R_00867C_CP_BUSY_STAT     = 0xFFFFFFFF
2013-04-02T12:46:27.262115+02:00 apophis kernel: [ 1828.824209] radeon 0000:01:00.0:   R_008680_CP_STAT          = 0xFFFFFFFF
2013-04-02T12:46:27.994081+02:00 apophis kernel: [ 1829.553641] radeon 0000:01:00.0: limiting VRAM
2013-04-02T12:46:27.994095+02:00 apophis kernel: [ 1829.553653] radeon 0000:01:00.0: VRAM: 3584M 0x0000000000000000 - 0x00000000DFFFFFFF (3584M used)
2013-04-02T12:46:27.994096+02:00 apophis kernel: [ 1829.553659] radeon 0000:01:00.0: GTT: 512M 0x00000000E0000000 - 0x00000000FFFFFFFF
2013-04-02T12:46:27.994097+02:00 apophis kernel: [ 1829.553675] mtrr: no more MTRRs available
2013-04-02T12:46:27.994098+02:00 apophis kernel: [ 1829.553679] [drm] Detected VRAM RAM=3584M, BAR=256M
2013-04-02T12:46:27.994099+02:00 apophis kernel: [ 1829.553682] [drm] RAM width 128bits DDR
2013-04-02T12:46:27.994100+02:00 apophis kernel: [ 1829.553859] [TTM] Zone  kernel: Available graphics memory: 4053020 kiB
2013-04-02T12:46:27.994100+02:00 apophis kernel: [ 1829.553866] [TTM] Zone   dma32: Available graphics memory: 2097152 kiB
2013-04-02T12:46:27.994101+02:00 apophis kernel: [ 1829.553870] [TTM] Initializing pool allocator
2013-04-02T12:46:27.994102+02:00 apophis kernel: [ 1829.553880] [TTM] Initializing DMA pool allocator
2013-04-02T12:46:27.994103+02:00 apophis kernel: [ 1829.553929] [drm] radeon: 3584M of VRAM memory ready
2013-04-02T12:46:27.994103+02:00 apophis kernel: [ 1829.553933] [drm] radeon: 512M of GTT memory ready.
2013-04-02T12:46:27.994104+02:00 apophis kernel: [ 1829.553967] [drm] Supports vblank timestamp caching Rev 1 (10.10.2010).
2013-04-02T12:46:27.994105+02:00 apophis kernel: [ 1829.553970] [drm] Driver supports precise vblank timestamp query.
2013-04-02T12:46:27.994106+02:00 apophis kernel: [ 1829.554021] [drm] radeon: irq initialized.
2013-04-02T12:46:27.994106+02:00 apophis kernel: [ 1829.554030] [drm] GART: num cpu pages 131072, num gpu pages 131072
2013-04-02T12:46:27.994107+02:00 apophis kernel: [ 1829.555334] [drm] probing gen 2 caps for device 8086:101 = 2/0
2013-04-02T12:46:27.994108+02:00 apophis kernel: [ 1829.555339] [drm] PCIE gen 2 link speeds already enabled
2013-04-02T12:46:27.994108+02:00 apophis kernel: [ 1829.555439] [drm] Loading TURKS Microcode
2013-04-02T12:46:28.966010+02:00 apophis kernel: [ 1830.524411] radeon 0000:01:00.0: Wait for MC idle timedout !
2013-04-02T12:46:29.090044+02:00 apophis kernel: [ 1830.646315] radeon 0000:01:00.0: Wait for MC idle timedout !
2013-04-02T12:46:29.914583+02:00 apophis kernel: [ 1831.376370] [drm] PCIE GART of 512M enabled (table at 0x0000000000040000).
2013-04-02T12:46:29.914616+02:00 apophis kernel: [ 1831.376440] divide error: 0000 [#1] SMP 
2013-04-02T12:46:29.914617+02:00 apophis kernel: [ 1831.376510] Modules linked in: radeon(+) cpufreq_stats fuse af_packet xt_tcpudp xt_pkttype xt_LOG xt_limit bnep bluetooth ip6t_REJECT nf_conntrack_ipv6 nf_defrag_ipv6 ip6table_raw ipt_REJECT iptable_raw xt_CT iptable_filter ip6table_mangle nf_conntrack_netbios_ns nf_conntrack_broadcast nf_conntrack_ipv4 nf_defrag_ipv4 ip_tables xt_conntrack nf_conntrack ip6table_filter ip6_tables x_tables cpufreq_conservative cpufreq_userspace cpufreq_powersave acpi_cpufreq mperf coretemp kvm_intel kvm snd_hda_codec_hdmi crc32c_intel ghash_clmulni_intel aesni_intel snd_hda_codec_realtek arc4 iwldvm mac80211 snd_hda_intel snd_hda_codec ablk_helper cryptd tpm_infineon lrw aes_x86_64 xts uvcvideo snd_hwdep gf128mul snd_pcm videobuf2_core videodev videobuf2_vmalloc iwlwifi videobuf2_memops tpm_tis i2c_i801 sony_laptop iTCO_wdt r8169 tpm iTCO_vendor_support mei lpc_ich mfd_core sr_mod snd_seq sg pcspkr snd_timer snd_seq_device battery microcode snd cfg80211 soundcore rfkill snd_page_alloc ac cdrom tpm_bios autofs4 xhci_hcd i915 ehci_hcd ttm usbcore drm_kms_helper usb_common drm i2c_algo_bit thermal video button processor thermal_sys scsi_dh_emc scsi_dh_rdac scsi_dh_hp_sw scsi_dh_alua scsi_dh [last unloaded: radeon]
2013-04-02T12:46:29.914619+02:00 apophis kernel: [ 1831.378143] CPU 3 
2013-04-02T12:46:29.914620+02:00 apophis kernel: [ 1831.378174] Pid: 3034, comm: modprobe Not tainted 3.7.10-1-default-patched #5 Sony Corporation VPCSA4W9E/VAIO
2013-04-02T12:46:29.914621+02:00 apophis kernel: [ 1831.378281] RIP: 0010:[<ffffffffa07f4f60>]  [<ffffffffa07f4f60>] r6xx_remap_render_backend+0x70/0xe0 [radeon]
2013-04-02T12:46:29.914622+02:00 apophis kernel: [ 1831.378449] RSP: 0018:ffff880254d89c40  EFLAGS: 00010246
2013-04-02T12:46:29.914622+02:00 apophis kernel: [ 1831.378509] RAX: 0000000000000004 RBX: 0000000000000000 RCX: 0000000000000000
2013-04-02T12:46:29.914623+02:00 apophis kernel: [ 1831.378585] RDX: 0000000000000000 RSI: 0000000000000000 RDI: ffff8802512b0000
2013-04-02T12:46:29.914624+02:00 apophis kernel: [ 1831.378661] RBP: 0000000000000002 R08: 00000000000000ff R09: 0000000000000000
2013-04-02T12:46:29.914634+02:00 apophis kernel: [ 1831.378737] R10: 0000000000000001 R11: 0000000000000008 R12: 0000000000000002
2013-04-02T12:46:29.914636+02:00 apophis kernel: [ 1831.378813] R13: 0000000000000004 R14: 00000000ffffffff R15: ffff8802506e6380
2013-04-02T12:46:29.914639+02:00 apophis kernel: [ 1831.378891] FS:  00007f2f1310f700(0000) GS:ffff88025fac0000(0000) knlGS:0000000000000000
2013-04-02T12:46:29.914642+02:00 apophis kernel: [ 1831.378978] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
2013-04-02T12:46:29.914644+02:00 apophis kernel: [ 1831.379041] CR2: 00007f5ebd0ea000 CR3: 00000002513c8000 CR4: 00000000000407e0
2013-04-02T12:46:29.914647+02:00 apophis kernel: [ 1831.379117] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
2013-04-02T12:46:29.914649+02:00 apophis kernel: [ 1831.379193] DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
2013-04-02T12:46:29.914652+02:00 apophis kernel: [ 1831.379271] Process modprobe (pid: 3034, threadinfo ffff880254d88000, task ffff88024c31e580)
2013-04-02T12:46:29.914654+02:00 apophis kernel: [ 1831.379359] Stack:
2013-04-02T12:46:29.914657+02:00 apophis kernel: [ 1831.379384]  ffff8802512b0000 00000000000000ff 0000000002010002 0000000040000000
2013-04-02T12:46:29.914659+02:00 apophis kernel: [ 1831.379479]  ffffffffa080aaf9 0000000000000282 ffffffff00000018 ffff880254d89cc8
2013-04-02T12:46:29.914662+02:00 apophis kernel: [ 1831.379573]  ffff880254d89c88 ffff8802512b0000 ffff8802512b0000 0000000000000000
2013-04-02T12:46:29.914664+02:00 apophis kernel: [ 1831.379668] Call Trace:
2013-04-02T12:46:29.914667+02:00 apophis kernel: [ 1831.379928]  [<ffffffffa080aaf9>] evergreen_gpu_init+0x269/0xc20 [radeon]
2013-04-02T12:46:29.914669+02:00 apophis kernel: [ 1831.380226]  [<ffffffffa080eff4>] evergreen_startup+0x1d4/0xa60 [radeon]
2013-04-02T12:46:29.914672+02:00 apophis kernel: [ 1831.380517]  [<ffffffffa080f9f6>] evergreen_init+0x176/0x290 [radeon]
2013-04-02T12:46:29.914674+02:00 apophis kernel: [ 1831.380815]  [<ffffffffa07b15a2>] radeon_device_init+0x532/0x620 [radeon]
2013-04-02T12:46:29.914677+02:00 apophis kernel: [ 1831.384920]  [<ffffffffa07b2f54>] radeon_driver_load_kms+0x84/0x170 [radeon]
2013-04-02T12:46:29.914680+02:00 apophis kernel: [ 1831.389039]  [<ffffffffa00a77e5>] drm_get_pci_dev+0x185/0x2a0 [drm]
2013-04-02T12:46:29.914682+02:00 apophis kernel: [ 1831.393077]  [<ffffffff812d96c6>] local_pci_probe+0x46/0x80
2013-04-02T12:46:29.914685+02:00 apophis kernel: [ 1831.397045]  [<ffffffff812d9912>] pci_device_probe+0x122/0x130
2013-04-02T12:46:29.914688+02:00 apophis kernel: [ 1831.401000]  [<ffffffff813826bd>] driver_probe_device+0x7d/0x380
2013-04-02T12:46:29.914691+02:00 apophis kernel: [ 1831.404944]  [<ffffffff81382a53>] __driver_attach+0x93/0xa0
2013-04-02T12:46:29.914693+02:00 apophis kernel: [ 1831.408876]  [<ffffffff813808fd>] bus_for_each_dev+0x4d/0x80
2013-04-02T12:46:29.914696+02:00 apophis kernel: [ 1831.412796]  [<ffffffff81381ce0>] bus_add_driver+0x180/0x280
2013-04-02T12:46:29.914698+02:00 apophis kernel: [ 1831.416727]  [<ffffffff81383094>] driver_register+0x84/0x180
2013-04-02T12:46:29.914701+02:00 apophis kernel: [ 1831.420605]  [<ffffffff810002ea>] do_one_initcall+0x12a/0x180
2013-04-02T12:46:29.914704+02:00 apophis kernel: [ 1831.424449]  [<ffffffff810a4b02>] sys_init_module+0xb2/0x220
2013-04-02T12:46:29.914706+02:00 apophis kernel: [ 1831.428314]  [<ffffffff81549bed>] system_call_fastpath+0x1a/0x1f
2013-04-02T12:46:29.914709+02:00 apophis kernel: [ 1831.432140]  [<00007f2f12a2fe2a>] 0x7f2f12a2fe29
2013-04-02T12:46:29.914713+02:00 apophis kernel: [ 1831.435902] Code: 31 db 45 89 c1 66 0f 1f 44 00 00 44 89 cb 41 d1 e9 83 e3 01 41 01 db 83 ee 01 75 ef 89 c1 44 29 d9 41 39 cd 72 6b 31 d2 44 89 e8 <f7> f1 0f af c8 41 89 c1 44 89 e8 29 c8 83 bf c0 00 00 00 27 19 
2013-04-02T12:46:29.914717+02:00 apophis kernel: [ 1831.444363] RIP  [<ffffffffa07f4f60>] r6xx_remap_render_backend+0x70/0xe0 [radeon]
2013-04-02T12:46:29.914720+02:00 apophis kernel: [ 1831.448575]  RSP <ffff880254d89c40>
2013-04-02T12:46:29.914722+02:00 apophis kernel: [ 1831.473249] ---[ end trace 8f29e167bc8c5823 ]---

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4523 bytes --]