From: Florian Fainelli <florian@openwrt.org>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Felipe Balbi <balbi@ti.com>,
Kernel development list <linux-kernel@vger.kernel.org>,
arnd@arndb.de, gregkh@linuxfoundation.org,
USB list <linux-usb@vger.kernel.org>
Subject: Re: [PATCH 1/5 v2] USB: regroup all depends on USB within an if USB block
Date: Wed, 03 Apr 2013 14:11:13 +0200 [thread overview]
Message-ID: <515C1C61.50301@openwrt.org> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1304021359130.1314-100000@iolanthe.rowland.org>
Le 04/02/13 20:06, Alan Stern a écrit :
> On Tue, 2 Apr 2013, Florian Fainelli wrote:
>
>> This patch removes the depends on USB from all config symbols in
>> drivers/usb/host/Kconfig and replace that with an if USB / endif block
>> as suggested by Alan Stern. Some source ... Kconfig lines have been
>> shuffled around to permit a better regroupment of the Kconfig files
>> depending on "config USB" item. No functionnal change is introduced.
>
> This looks almost right. The only problem I see is in
> drivers/usb/core/Kconfig. The USB_OTG_WHITELIST and
> USB_OTG_BLACKLIST_HUB symbols don't have to depend on USB or USB_OTG,
> because they can be set if EXPERT is enabled.
>
> To avoid these issues, I think the best approach is to move all the
> USB_OTG* entries over to drivers/usb/otg/Kconfig, where by rights they
> should have been all along.
>
> Felipe, do you agree?
Make sense, I will make this a sixth patch to this serie if this sounds
right with you?
--
Florian
next prev parent reply other threads:[~2013-04-03 12:11 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-26 18:06 [RFC PATCH 0/5] USB: Kconfig cleanups Florian Fainelli
2013-03-26 18:06 ` [RFC PATCH 1/5] USB: drop depends on USB and enclose everything into an if USB block Florian Fainelli
2013-03-26 19:04 ` Alan Stern
2013-03-26 19:56 ` Florian Fainelli
2013-03-26 18:06 ` [RFC PATCH 2/5] USB: remove USB_EHCI_BIG_ENDIAN_{DESC,MMIO} depends on architecture symbol Florian Fainelli
2013-03-26 18:10 ` Arnd Bergmann
2013-03-26 19:08 ` Alan Stern
2013-03-29 21:31 ` Anatolij Gustschin
2013-03-26 18:06 ` [RFC PATCH 3/5] USB: enclose EHCI HCD drivers within an if USB_EHCI_HCD block Florian Fainelli
2013-03-26 18:06 ` [RFC PATCH 4/5] USB: enclose all depends on USB_OHCI_HCD within an if USB_OHCI_HCD block Florian Fainelli
2013-03-26 18:06 ` [RFC PATCH 5/5] USB: enclose USB_XHCI_HCD related symbols within a if USB_XHCI_HCD block Florian Fainelli
2013-04-02 17:05 ` [PATCH 0/5] USB: Kconfig cleanups Florian Fainelli
2013-04-02 17:05 ` [PATCH 1/5] USB: regroup all depends on USB within an if USB block Florian Fainelli
2013-04-02 17:05 ` [PATCH 2/5] USB: remove USB_EHCI_BIG_ENDIAN_{DESC,MMIO} depends on architecture symbol Florian Fainelli
2013-04-02 17:05 ` [PATCH 3/5] USB: enclose EHCI HCD drivers within an if USB_EHCI_HCD block Florian Fainelli
2013-04-02 17:05 ` [PATCH 4/5] USB: enclose all depends on USB_OHCI_HCD within an if USB_OHCI_HCD block Florian Fainelli
2013-04-02 17:05 ` [PATCH 5/5] USB: enclose USB_XHCI_HCD related symbols within a if USB_XHCI_HCD block Florian Fainelli
2013-04-02 17:10 ` [PATCH 0/5] USB: Kconfig cleanups Florian Fainelli
2013-04-02 17:10 ` [PATCH 0/5 v2] " Florian Fainelli
2013-04-02 17:10 ` [PATCH 1/5 v2] USB: regroup all depends on USB within an if USB block Florian Fainelli
2013-04-02 18:06 ` Alan Stern
2013-04-03 12:11 ` Florian Fainelli [this message]
2013-04-03 12:15 ` Felipe Balbi
2013-04-03 12:18 ` Florian Fainelli
2013-04-03 12:21 ` Felipe Balbi
2013-04-03 18:10 ` Alan Stern
2013-04-02 18:19 ` balbi
2013-04-03 11:54 ` Florian Fainelli
2013-04-02 17:10 ` [PATCH 2/5 v2] USB: remove USB_EHCI_BIG_ENDIAN_{DESC,MMIO} depends on architecture symbol Florian Fainelli
2013-04-02 18:21 ` Alan Stern
2013-04-02 17:10 ` [PATCH 3/5 v2] USB: enclose EHCI HCD drivers within an if USB_EHCI_HCD block Florian Fainelli
2013-04-02 18:33 ` Alan Stern
2013-04-02 17:10 ` [PATCH 4/5 v2] USB: enclose all depends on USB_OHCI_HCD within an if USB_OHCI_HCD block Florian Fainelli
2013-04-02 18:42 ` Alan Stern
2013-04-02 17:10 ` [PATCH 5/5 v2] USB: enclose USB_XHCI_HCD related symbols within a if USB_XHCI_HCD block Florian Fainelli
2013-04-02 18:43 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515C1C61.50301@openwrt.org \
--to=florian@openwrt.org \
--cc=arnd@arndb.de \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox