From: Matt Fleming <matt@console-pimps.org>
To: Matthew Garrett <matthew.garrett@nebula.com>
Cc: matt.fleming@intel.com, ben@decadent.org.uk, jwboyer@redhat.com,
linux-efi@vger.kernel.org, seth.forshee@canonical.com,
linux-kernel@vger.kernel.org, x86@kernel.org
Subject: Re: [PATCH 1/2] efi: Determine how much space is used by boot services-only variables
Date: Wed, 03 Apr 2013 14:09:02 +0100 [thread overview]
Message-ID: <515C29EE.8050008@console-pimps.org> (raw)
In-Reply-To: <1364829240-26475-1-git-send-email-matthew.garrett@nebula.com>
On 01/04/13 16:13, Matthew Garrett wrote:
> EFI variables can be flagged as being accessible only within boot services.
> This makes it awkward for us to figure out how much space they use at
> runtime. In theory we could figure this out by simply comparing the results
> from QueryVariableInfo() to the space used by all of our variables, but
> that fails if the platform doesn't garbage collect on every boot. Thankfully,
> calling QueryVariableInfo() while still inside boot services gives a more
> reliable answer. This patch passes that information from the EFI boot stub
> up to the efivars code, letting us calculate a reasonably accurate value.
>
> Signed-off-by: Matthew Garrett <matthew.garrett@nebula.com>
> ---
> arch/x86/boot/compressed/eboot.c | 47 +++++++++++++++++++++++++++++++++++
> arch/x86/include/asm/efi.h | 10 ++++++++
> arch/x86/include/uapi/asm/bootparam.h | 1 +
> arch/x86/platform/efi/efi.c | 21 ++++++++++++++++
> drivers/firmware/efivars.c | 29 +++++++++++++++++++++
> 5 files changed, 108 insertions(+)
We're fixing a regression in efivars.c, but only for those users that
boot via the EFI boot stub? That seems likely to upset some people.
Introducing new features via the EFI boot stub is fine, and working
around firmware bugs so that we can use some feature is also cool, but
we can't start fixing regressions from other subsystems in the EFI boot
stub.
--
Matt Fleming, Intel Open Source Technology Center
next prev parent reply other threads:[~2013-04-03 13:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <515150EC.7040203@redhat.com>
2013-04-01 15:13 ` [PATCH 1/2] efi: Determine how much space is used by boot services-only variables Matthew Garrett
2013-04-01 15:14 ` [PATCH 2/2] efi: Distinguish between "remaining space" and actually used space Matthew Garrett
2013-04-01 15:50 ` Ben Hutchings
2013-04-03 13:11 ` Matt Fleming
2013-04-03 13:48 ` Matthew Garrett
2013-04-03 17:12 ` Matt Fleming
2013-04-03 17:20 ` Matthew Garrett
2013-04-01 15:42 ` [PATCH 1/2] efi: Determine how much space is used by boot services-only variables Ben Hutchings
2013-04-03 13:09 ` Matt Fleming [this message]
2013-04-03 13:42 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515C29EE.8050008@console-pimps.org \
--to=matt@console-pimps.org \
--cc=ben@decadent.org.uk \
--cc=jwboyer@redhat.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=matthew.garrett@nebula.com \
--cc=seth.forshee@canonical.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox