From: Chen Gang <gang.chen@asianux.com>
To: "Arve Hjønnevåg" <arve@android.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
Dan Carpenter <dan.carpenter@oracle.com>,
Al Viro <viro@zeniv.linux.org.uk>,
Mirsal Ennaime <mirsal@mirsal.fr>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Staging: Android: looping issue, need break when get value firstly.
Date: Sat, 06 Apr 2013 13:05:59 +0800 [thread overview]
Message-ID: <515FAD37.4090300@asianux.com> (raw)
In-Reply-To: <CAMP5Xgd=wVrDVCc84L2kMk9ADy7avokB6D=4+kdAm8jF+NLVyg@mail.gmail.com>
On 2013年04月06日 07:48, Arve Hjønnevåg wrote:
> On Fri, Apr 5, 2013 at 3:01 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
>> > On Fri, Apr 05, 2013 at 04:05:25PM +0800, Chen Gang wrote:
>>> >>
>>> >> need break when 'target_thread' get value, firstly.
>>> >>
>>> >> 'tmp' is a stack (thread->transaction_stack),
>>> >> if 'proc' was the same between child node and parent node,
>>> >> the child would have higher priority than parent.
>> >
>> > Are you sure about this?
>> >
>> > have you tested it?
>> >
> Theoretically this should not change the behavior. The purpose of this
> code it to make sure only thread per process is part of a transaction
> stack, so if it finds more than one transaction with a matching
> process, they should all point to the same thread object. I think a
> better change description is needed though.
ok, thanks.
I will send patch v2 (also mark you as Signed-off).
(if the patch v2 still need improvement, please reply in time).
thanks.
:-)
--
Chen Gang
Asianux Corporation
next prev parent reply other threads:[~2013-04-06 5:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <515E85C5.7010706@asianux.com>
2013-04-05 22:01 ` [PATCH] Staging: Android: looping issue, need break when get value firstly Greg KH
2013-04-05 23:48 ` Arve Hjønnevåg
2013-04-06 5:05 ` Chen Gang [this message]
2013-04-06 5:43 ` Chen Gang
2013-04-06 5:57 ` Greg KH
2013-04-06 7:28 ` Chen Gang
2013-04-06 9:47 ` Chen Gang
2013-04-06 5:13 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515FAD37.4090300@asianux.com \
--to=gang.chen@asianux.com \
--cc=arve@android.com \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mirsal@mirsal.fr \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox