public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Chen Gang <gang.chen@asianux.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Greg KH <gregkh@linuxfoundation.org>,
	"linux-kernel@vger.kernel.org >>
	\"linux-kernel@vger.kernel.org\""  <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Drivers: Misc: fix warnings, unsigned long will never < 0
Date: Sun, 07 Apr 2013 11:26:58 +0800	[thread overview]
Message-ID: <5160E782.4050400@asianux.com> (raw)
In-Reply-To: <5160E37C.3020007@asianux.com>


  also has another 'unsigned long val' warnings, I will send patch v2 to
merge them together.


On 2013年04月07日 11:09, Chen Gang wrote:
> 
>   val is unsigned long which never < 0
> 
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
> ---
>  drivers/misc/tsl2550.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/misc/tsl2550.c b/drivers/misc/tsl2550.c
> index 1e7bc0e..558dd20 100644
> --- a/drivers/misc/tsl2550.c
> +++ b/drivers/misc/tsl2550.c
> @@ -204,7 +204,7 @@ static ssize_t tsl2550_store_power_state(struct device *dev,
>  	unsigned long val = simple_strtoul(buf, NULL, 10);
>  	int ret;
>  
> -	if (val < 0 || val > 1)
> +	if (val > 1)
>  		return -EINVAL;
>  
>  	mutex_lock(&data->update_lock);
> 


-- 
Chen Gang

Asianux Corporation

  reply	other threads:[~2013-04-07  3:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-07  3:09 [PATCH] Drivers: Misc: fix warnings, unsigned long will never < 0 Chen Gang
2013-04-07  3:26 ` Chen Gang [this message]
2013-04-07  3:28 ` [PATCH v2] " Chen Gang
2013-05-08  2:24   ` Chen Gang
2013-05-08  2:38     ` Greg KH
2013-05-08  2:46       ` Li Zefan
2013-05-08  2:49         ` Chen Gang
2013-05-08  2:54         ` Greg KH
2013-05-08  3:27           ` Chen Gang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5160E782.4050400@asianux.com \
    --to=gang.chen@asianux.com \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox