public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Chen Gang <gang.chen@asianux.com>
To: rusty@rustcorp.com.au
Cc: "linux-kernel@vger.kernel.org >>
	\"linux-kernel@vger.kernel.org\""  <linux-kernel@vger.kernel.org>
Subject: [PATCH] kernel: module: strncpy issue, using strlcpy instead of strncpy
Date: Sun, 07 Apr 2013 19:38:24 +0800	[thread overview]
Message-ID: <51615AB0.9060502@asianux.com> (raw)


  ownername and namebuf are all NUL terminated string.

  need always let them ended by '\0'.

Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
 kernel/module.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/module.c b/kernel/module.c
index 3c2c72d..597efd8 100644
--- a/kernel/module.c
+++ b/kernel/module.c
@@ -1283,7 +1283,7 @@ static const struct kernel_symbol *resolve_symbol(struct module *mod,
 
 getname:
 	/* We must make copy under the lock if we failed to get ref. */
-	strncpy(ownername, module_name(owner), MODULE_NAME_LEN);
+	strlcpy(ownername, module_name(owner), MODULE_NAME_LEN);
 unlock:
 	mutex_unlock(&module_mutex);
 	return sym;
@@ -3464,7 +3464,7 @@ const char *module_address_lookup(unsigned long addr,
 	}
 	/* Make a copy in here where it's safe */
 	if (ret) {
-		strncpy(namebuf, ret, KSYM_NAME_LEN - 1);
+		strlcpy(namebuf, ret, KSYM_NAME_LEN);
 		ret = namebuf;
 	}
 	preempt_enable();
-- 
1.7.7.6

             reply	other threads:[~2013-04-07 11:38 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-07 11:38 Chen Gang [this message]
2013-04-07 14:28 ` [PATCH] kernel: module: strncpy issue, using strlcpy instead of strncpy Geert Uytterhoeven
2013-04-08  2:48   ` Chen Gang
2013-04-08  3:02     ` Chen Gang
2013-04-08  5:30 ` Rusty Russell
2013-04-08 10:16   ` Chen Gang
2013-04-08 13:45     ` Rusty Russell
2013-04-09  1:52       ` Chen Gang
2013-04-09  9:36         ` Chen Gang
2013-04-09  9:55           ` Chen Gang
2013-04-10  6:00           ` Chen Gang
2013-04-09  2:47     ` [PATCH v2] kernel: module: using strlcpy and strcpy " Chen Gang
2013-04-10  1:22       ` Rusty Russell
2013-04-10  4:13         ` [PATCH v3] " Chen Gang
2013-04-10  6:52           ` Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51615AB0.9060502@asianux.com \
    --to=gang.chen@asianux.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox