From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933935Ab3DGP31 (ORCPT ); Sun, 7 Apr 2013 11:29:27 -0400 Received: from mail-pd0-f173.google.com ([209.85.192.173]:43652 "EHLO mail-pd0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933901Ab3DGP30 (ORCPT ); Sun, 7 Apr 2013 11:29:26 -0400 Message-ID: <516190CD.8040800@gmail.com> Date: Sun, 07 Apr 2013 23:29:17 +0800 From: Jiang Liu User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130308 Thunderbird/17.0.4 MIME-Version: 1.0 To: Hans-Christian Egtvedt CC: Jiang Liu , Haavard Skinnemoen , linux-kernel@vger.kernel.org Subject: Re: [PATCH] AVR32: fix building warnings caused by redifinitions of HZ References: <1365266616-8424-1-git-send-email-jiang.liu@huawei.com> <20130407075526.GA28026@samfundet.no> In-Reply-To: <20130407075526.GA28026@samfundet.no> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/07/2013 03:55 PM, Hans-Christian Egtvedt wrote: > Around Sun 07 Apr 2013 00:43:36 +0800 or thereabout, Jiang Liu wrote: >> Fix building warnings caused by redifinitions of HZ: >> In file included from /ws/linux/kernel/linux.git/include/uapi/linux/param.h:4, >> from include/linux/timex.h:63, >> from include/linux/jiffies.h:8, >> from include/linux/ktime.h:25, >> from include/linux/timer.h:5, >> from include/linux/workqueue.h:8, >> from include/linux/srcu.h:34, >> from include/linux/notifier.h:15, >> from include/linux/memory_hotplug.h:6, >> from include/linux/mmzone.h:777, >> from include/linux/gfp.h:4, >> from arch/avr32/mm/init.c:10: >> /ws/linux/kernel/linux.git/arch/avr32/include/asm/param.h:6:1: warning: "HZ" redefined >> In file included from /ws/linux/kernel/linux.git/arch/avr32/include/asm/param.h:4, >> from /ws/linux/kernel/linux.git/include/uapi/linux/param.h:4, >> from include/linux/timex.h:63, >> from include/linux/jiffies.h:8, >> from include/linux/ktime.h:25, >> from include/linux/timer.h:5, >> from include/linux/workqueue.h:8, >> from include/linux/srcu.h:34, >> from include/linux/notifier.h:15, >> from include/linux/memory_hotplug.h:6, >> from include/linux/mmzone.h:777, >> from include/linux/gfp.h:4, >> from arch/avr32/mm/init.c:10: >> /ws/linux/kernel/linux.git/arch/avr32/include/uapi/asm/param.h:6:1: warning: this is the location of the previous definition > > Thanks for fixing. > >> Signed-off-by: Jiang Liu >> Cc: Haavard Skinnemoen >> Cc: Hans-Christian Egtvedt >> Cc: linux-kernel@vger.kernel.org > > Acked-by: Hans-Christian Egtvedt > >> --- >> arch/avr32/include/uapi/asm/param.h | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/arch/avr32/include/uapi/asm/param.h b/arch/avr32/include/uapi/asm/param.h >> index d28aa5e..abda103 100644 >> --- a/arch/avr32/include/uapi/asm/param.h >> +++ b/arch/avr32/include/uapi/asm/param.h >> @@ -2,7 +2,11 @@ >> #define _UAPI__ASM_AVR32_PARAM_H >> >> >> -#ifndef HZ >> +#ifndef __KERNEL__ >> + /* >> + * Technically, this is wrong, but some old apps still refer to it. >> + * The proper way to get the HZ value is via sysconf(_SC_CLK_TCK). >> + */ > > With this comment, are there AVR32 drivers/users that should be fixed? Or is > it parts of the tree in general? Hi Hans, It's copied from arch/ia64/include/uapi/asm/param.h, I feel it should be the same for AVR32 too. Regards! Gerry > >> # define HZ 100 >> #endif >>