From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Lai Jiangshan <laijs@cn.fujitsu.com>
Cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org, tglx@linutronix.de
Subject: Re: [PATCH 1/3] kernel/srcu: merge common code into a macro
Date: Mon, 08 Apr 2013 12:05:58 +0200 [thread overview]
Message-ID: <51629686.7030708@linutronix.de> (raw)
In-Reply-To: <515E7B77.7010807@cn.fujitsu.com>
On 04/05/2013 09:21 AM, Lai Jiangshan wrote:
> Hi, Sebastian
Hi Lai,
> The patch hurts readability.
> The original code are simple enough, merging them as one macro
> gives us no benefit.
Except when you need to adjust the macro and you have to touch both of
them instead just one. But I don't have strong feelings for that one.
> Thanks
> Lai.
Sebastian
prev parent reply other threads:[~2013-04-08 10:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-19 14:16 [PATCH 1/3] kernel/srcu: merge common code into a macro Sebastian Andrzej Siewior
2013-03-19 14:16 ` [PATCH 2/3] kernel/SRCU: provide a static initializer Sebastian Andrzej Siewior
2013-04-05 7:21 ` Lai Jiangshan
2013-04-08 10:03 ` Sebastian Andrzej Siewior
2013-04-09 1:09 ` Lai Jiangshan
2013-04-11 17:04 ` Sebastian Andrzej Siewior
2013-04-12 2:56 ` Lai Jiangshan
2013-04-16 18:20 ` Paul E. McKenney
2013-03-19 14:16 ` [PATCH 3/3] cpufreq: use static initializer for the SRCU notifier Sebastian Andrzej Siewior
2013-03-19 16:22 ` [PATCH 1/3] kernel/srcu: merge common code into a macro Joe Perches
2013-03-19 18:15 ` Sebastian Andrzej Siewior
2013-04-05 7:21 ` Lai Jiangshan
2013-04-08 10:05 ` Sebastian Andrzej Siewior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51629686.7030708@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).