From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935785Ab3DHNWh (ORCPT ); Mon, 8 Apr 2013 09:22:37 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:40595 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935709Ab3DHNWe (ORCPT ); Mon, 8 Apr 2013 09:22:34 -0400 Message-ID: <5162C44B.90501@ti.com> Date: Mon, 8 Apr 2013 18:51:15 +0530 From: Kishon Vijay Abraham I User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 MIME-Version: 1.0 To: Stephen Warren CC: , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v5 1/6] drivers: phy: add generic PHY framework References: <1364993634-6378-1-git-send-email-kishon@ti.com> <1364993634-6378-2-git-send-email-kishon@ti.com> <515CC123.4060402@wwwdotorg.org> In-Reply-To: <515CC123.4060402@wwwdotorg.org> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Thursday 04 April 2013 05:24 AM, Stephen Warren wrote: > On 04/03/2013 06:53 AM, Kishon Vijay Abraham I wrote: >> The PHY framework provides a set of APIs for the PHY drivers to >> create/destroy a PHY and APIs for the PHY users to obtain a reference to the >> PHY with or without using phandle. To obtain a reference to the PHY without >> using phandle, the platform specfic intialization code (say from board file) >> should have already called phy_bind with the binding information. The binding >> information consists of phy's device name, phy user device name and an index. >> The index is used when the same phy user binds to mulitple phys. >> >> PHY drivers should create the PHY by passing phy_descriptor that has >> describes the PHY (label, type etc..) and ops like init, exit, suspend, resume, >> power_on, power_off. >> >> The documentation for the generic PHY framework is added in >> Documentation/phy.txt and the documentation for the sysfs entry is added >> in Documentation/ABI/testing/sysfs-class-phy and the documentation for >> dt binding is can be found at >> Documentation/devicetree/bindings/phy/phy-bindings.txt > >> diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h > >> +extern struct phy *devm_phy_create(struct device *dev, const char *label, >> + struct device_node *of_node, int type, struct phy_ops *ops, >> + void *priv); > > Can't the function get of_node from dev->of_node? > > I wonder if we shouldn't split up the registration a bit though: > > A function which registers a PHY object itself. That's the function above. > > A function which registers a DT-based PHY provider. > > Then, the of_xlate op would be part of the PHY provider, not part of > some random PHY that happens to exist on that node. So: Yeah. Makes sense to me. By this we can avoid struct phy * to represent two different things (phy provider and phy instance). Thanks Kishon