From: "H. Peter Anvin" <hpa@zytor.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: Robin Holt <holt@sgi.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, Russ Anderson <rja@sgi.com>,
Shawn Guo <shawn.guo@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
x86@kernel.org, Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] Do not force shutdown/reboot to boot cpu.
Date: Mon, 08 Apr 2013 09:11:06 -0700 [thread overview]
Message-ID: <5162EC1A.4050204@zytor.com> (raw)
In-Reply-To: <20130408155701.GB19974@gmail.com>
On 04/08/2013 08:57 AM, Ingo Molnar wrote:
>
> I think the original commit:
>
> f96972f2dc63 kernel/sys.c: call disable_nonboot_cpus() in kernel_restart()
>
> actually regressed your 1024 CPU systems, and should possibly be reverted or fixed
> in some other fashion - such as by migrating to the primary CPU (on architectures
> that require that), instead of hotplug offlining every secondary CPU on every
> architecture!
>
> Alternatively, disable_nonboot_cpus() could perhaps be improved to down CPUs in
> parallel: issue the CPU-down requests to every CPU, then wait for them to complete
> - instead of the loop over every CPU?
>
> This would be the conceptual counter part to parallel boot up of CPUs - something
> SGI might be interested in as well?
>
Migrating to the boot processor and then calling stop_machine() to
defang any other processors should be sufficient, no?
I don't know if there is any reason to deschedule all tasks?
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
next prev parent reply other threads:[~2013-04-08 16:11 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-03 19:37 [PATCH] Do not force shutdown/reboot to boot cpu Robin Holt
2013-04-08 15:57 ` Ingo Molnar
2013-04-08 16:11 ` H. Peter Anvin [this message]
2013-04-08 16:59 ` Robin Holt
2013-04-10 11:16 ` Ingo Molnar
2013-04-10 14:01 ` Robin Holt
2013-04-10 15:10 ` Linus Torvalds
2013-04-10 15:29 ` Russ Anderson
2013-04-10 16:59 ` Ingo Molnar
2013-04-10 17:14 ` Robin Holt
2013-04-10 17:22 ` Ingo Molnar
2013-04-10 17:55 ` Robin Holt
2013-04-10 19:00 ` Robin Holt
2013-04-11 8:57 ` Ingo Molnar
2013-04-11 11:34 ` Robin Holt
2013-04-11 12:00 ` Ingo Molnar
2013-04-11 12:03 ` Robin Holt
2013-04-11 12:08 ` Robin Holt
2013-04-11 12:14 ` Ingo Molnar
2013-04-10 17:58 ` H. Peter Anvin
2013-04-10 23:02 ` Russ Anderson
2013-04-10 22:29 ` Russ Anderson
2013-04-11 5:31 ` Paul Mackerras
2013-04-11 12:45 ` Bulk CPU Hotplug (Was Re: [PATCH] Do not force shutdown/reboot to boot cpu.) Srivatsa S. Bhat
2013-04-11 13:48 ` Robin Holt
2013-04-12 5:37 ` Ingo Molnar
2013-04-12 6:09 ` Srivatsa S. Bhat
2013-04-12 9:31 ` Robin Holt
2013-04-12 10:01 ` Robin Holt
2013-04-13 16:30 ` Oleg Nesterov
2013-04-15 16:04 ` Robin Holt
2013-04-15 16:09 ` Oleg Nesterov
2013-04-15 16:10 ` Robin Holt
2013-04-13 17:01 ` Srivatsa S. Bhat
2013-04-15 10:16 ` Ingo Molnar
2013-04-15 12:02 ` Robin Holt
2013-04-15 15:59 ` Robin Holt
2013-04-16 9:40 ` Ingo Molnar
2013-04-11 14:23 ` Russ Anderson
2013-04-11 14:45 ` Srivatsa S. Bhat
2013-04-11 20:08 ` Russ Anderson
2013-04-11 20:17 ` Srivatsa S. Bhat
2013-04-11 21:08 ` Robin Holt
2013-04-08 16:54 ` [PATCH] Do not force shutdown/reboot to boot cpu Robin Holt
2013-04-08 17:07 ` Russ Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5162EC1A.4050204@zytor.com \
--to=hpa@zytor.com \
--cc=akpm@linux-foundation.org \
--cc=holt@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=rja@sgi.com \
--cc=shawn.guo@linaro.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox