Re: [PATCH 1/8] cgroup: implement cgroup_is_ancestor()

Tejun Heo
2013-04-08T15:39:50Z

Hello, Li.

On Mon, Apr 08, 2013 at 04:20:11PM +0800, Li Zefan wrote:
> +/**
> + * cgroup_is_ancestor - test "root" cgroup is an ancestor of "child"
> + * @child: the cgroup to be tested.
> + * @root: the cgroup supposed to be an ancestor of the child.

Please explain locking in the comment. (I know it only requires both
cgroups to be accessible but being explicit is nice.)

> + * Returns true if "root" is an ancestor of "child" in its hierarchy.
> + */
> +bool cgroup_is_ancestor(struct cgroup *child, struct cgroup *root)

s/root/ancestor/

> +{
> + int depth = child->depth;
> +
> + if (depth < root->depth)
> + return false;
> +
> + while (depth-- != root->depth)
> + child = child->parent;

Just walk up till it meets the ancestor or reaches root. Why bother
with depth?

Thanks.

--
tejun