Re: [PATCH RFC] ARM: dts: mxs: leave card detect out of common mmc pins config

Shawn Guo
2013-04-08T12:48:07Z

On Mon, Apr 08, 2013 at 12:12:20PM +0200, Hector Palacios wrote:
> MicroSD card sockets don't usually have card detect line. This pin
> is actually not needed for the MMC to work and it is more of a
> platform design decission to have it.
> The card detect pin already has a configuration entry of its own:
> 'mmc0_cd_cfg' so we complete the iomux configuration here and let
> platforms to include it or not depending on whether the card detect
> line is routed to the SD socket.
>
Sounds sensible.

> Signed-off-by: Hector Palacios <hector.palacios@digi.com>
> ---
>
> Hello,
>
> All imx28 based platforms except 'bluegiga,apx4devkit' and
> 'schulercontrol,imx28-sps1', use 'mmc0_cd_cfg' in their mmc configuration
> so please check whether this patch would break these platforms.
>
I just tested the patch on imx28-evk and card-detection still works. So
patches applied, thanks.

Shawn

> arch/arm/boot/dts/imx28.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi
> index 9b18e81..4222e4e 100644
> --- a/arch/arm/boot/dts/imx28.dtsi
> +++ b/arch/arm/boot/dts/imx28.dtsi
> @@ -449,7 +449,6 @@
> 0x2060 /* MX28_PAD_SSP0_DATA6__SSP0_D6 */
> 0x2070 /* MX28_PAD_SSP0_DATA7__SSP0_D7 */
> 0x2080 /* MX28_PAD_SSP0_CMD__SSP0_CMD */
> - 0x2090 /* MX28_PAD_SSP0_DETECT__SSP0_CARD_DETECT */
> 0x20a0 /* MX28_PAD_SSP0_SCK__SSP0_SCK */
> >;
> fsl,drive-strength = <1>;
> @@ -465,7 +464,6 @@
> 0x2020 /* MX28_PAD_SSP0_DATA2__SSP0_D2 */
> 0x2030 /* MX28_PAD_SSP0_DATA3__SSP0_D3 */
> 0x2080 /* MX28_PAD_SSP0_CMD__SSP0_CMD */
> - 0x2090 /* MX28_PAD_SSP0_DETECT__SSP0_CARD_DETECT */
> 0x20a0 /* MX28_PAD_SSP0_SCK__SSP0_SCK */
> >;
> fsl,drive-strength = <1>;
> @@ -477,6 +475,8 @@
> fsl,pinmux-ids = <
> 0x2090 /* MX28_PAD_SSP0_DETECT__SSP0_CARD_DETECT */
> >;
> + fsl,drive-strength = <1>;
> + fsl,voltage = <1>;
> fsl,pull-up = <0>;
> };
>
> --
> 1.8.2
>