From: Steffen Persvold <sp@numascale.com>
To: Borislav Petkov <bp@alien8.de>,
Daniel J Blueman <daniel@numascale-asia.com>,
Tony Luck <tony.luck@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, linux-edac@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86, amd, mce: Prevent potential cpu-online oops
Date: Tue, 09 Apr 2013 11:45:44 +0200 [thread overview]
Message-ID: <5163E348.7060206@numascale.com> (raw)
In-Reply-To: <20130409093854.GC10243@pd.tnic>
On 4/9/2013 11:38 AM, Borislav Petkov wrote:
> On Tue, Apr 09, 2013 at 11:25:16AM +0200, Steffen Persvold wrote:
>> Why not let all cores just create their individual kobject and skip
>> this "shared" nb->bank4 concept ? Any disadvantage to that (apart from
>> the obvious storage bloat?).
>
> Well, bank4 is shared across cores on the northbridge in *hardware*.
Well, yes I was aware of that :)
> So it is only logical to represent the hardware layout correctly in
> software.
>
> Also, if you want to configure any settings over one core's sysfs nodes,
> you want those to be visible across all cores automagically:
Hmm, yes of course. This of course breaks on our slave servers when the
shared mechanism doesn't work properly (i.e NB not visible). Then all
cores gets individual kobjects and there can be discrepancies between
what the hardware is programmed to and what is reflected in /sys on some
cores..
Ok, we go with our first approach to not create MC4 at all if NB isn't
visible.
We'll redo the patch against the tip:x86/ras branch.
Cheers,
Steffen
next prev parent reply other threads:[~2013-04-09 9:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-04 15:52 [PATCH] x86, amd, mce: Prevent potential cpu-online oops Daniel J Blueman
2013-04-04 16:04 ` Luck, Tony
2013-04-04 16:13 ` Borislav Petkov
2013-04-04 18:05 ` Steffen Persvold
2013-04-04 19:07 ` Borislav Petkov
2013-04-04 20:01 ` Steffen Persvold
2013-04-09 9:25 ` Steffen Persvold
2013-04-09 9:38 ` Borislav Petkov
2013-04-09 9:45 ` Steffen Persvold [this message]
2013-04-09 10:24 ` Borislav Petkov
2013-04-09 11:34 ` Steffen Persvold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5163E348.7060206@numascale.com \
--to=sp@numascale.com \
--cc=bp@alien8.de \
--cc=daniel@numascale-asia.com \
--cc=hpa@zytor.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox