public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Vivek Gautam <gautam.vivek@samsung.com>
Cc: linux-usb@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
	linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
	stern@rowland.harvard.edu, kgene.kim@samsung.com,
	Manjunath Goudar <manjunath.goudar@linaro.org>,
	Arnd Bergmann <arnd@arndb.de>, Jingoo Han <jg1.han@samsung.com>
Subject: Re: [PATCH] usb: ehci-s5p: fix: Fix null pointer dereferencing
Date: Tue, 09 Apr 2013 16:31:18 +0400	[thread overview]
Message-ID: <51640A16.1060002@cogentembedded.com> (raw)
In-Reply-To: <1365499312-14232-1-git-send-email-gautam.vivek@samsung.com>

Hello.

On 09-04-2013 13:21, Vivek Gautam wrote:

> 7edb3da makes ehci-s5p as a separate driver. But,

    Please also provide the summary line of that commit in parens.

> it raised an issue with its driver data.
> Now that 's5p_ehci_hcd' doesn't maintain pointer to 'usb_hcd'
> and s5p_ehci is nothing but a pointer to hcd->priv;
> add hcd to the driver data rather than s5p_ehci.

> This fixes issues with null pointer dereferencing in
> s5p_ehci_shutdown(), s5p_ehci_suspend(), s5p_ehci_resume().

> Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
> CC: Manjunath Goudar <manjunath.goudar@linaro.org>
> CC: Arnd Bergmann <arnd@arndb.de>
> CC: Jingoo Han <jg1.han@samsung.com>

WBR, Sergei



  parent reply	other threads:[~2013-04-09 12:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-09  9:21 [PATCH] usb: ehci-s5p: fix: Fix null pointer dereferencing Vivek Gautam
2013-04-09 10:26 ` Arnd Bergmann
2013-04-09 12:31 ` Sergei Shtylyov [this message]
2013-04-09 13:02   ` Vivek Gautam
2013-04-09 13:12     ` [PATCH v2] " Vivek Gautam
2013-04-22 17:16       ` Kukjin Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51640A16.1060002@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=arnd@arndb.de \
    --cc=gautam.vivek@samsung.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jg1.han@samsung.com \
    --cc=kgene.kim@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=manjunath.goudar@linaro.org \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox