Re: [PATCH v2] usb: ehci-s5p: fix: Fix null pointer dereferencing

Kukjin Kim
2013-04-22T17:16:55Z

On 04/09/13 22:12, Vivek Gautam wrote:
> 7edb3da: (USB: EHCI: make ehci-s5p a separate driver)
> raised an issue with ehci-s5p's driver data.
> Now that 's5p_ehci_hcd' doesn't maintain pointer to 'usb_hcd'
> and s5p_ehci is nothing but a pointer to hcd->priv;
> add hcd to the driver data rather than s5p_ehci.
>
> This fixes issues with null pointer dereferencing in
> s5p_ehci_shutdown(), s5p_ehci_suspend(), s5p_ehci_resume().
>
> Signed-off-by: Vivek Gautam<gautam.vivek@samsung.com>
> CC: Manjunath Goudar<manjunath.goudar@linaro.org>
> CC: Arnd Bergmann<arnd@arndb.de>
> CC: Jingoo Han<jg1.han@samsung.com>

Acked-by: Kukjin Kim <kgene.kim@samsung.com>

Thanks.

- Kukjin

> ---
>
> Based on 'usb-next'
>
> drivers/usb/host/ehci-s5p.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/usb/host/ehci-s5p.c b/drivers/usb/host/ehci-s5p.c
> index d8cb0ca..580548a 100644
> --- a/drivers/usb/host/ehci-s5p.c
> +++ b/drivers/usb/host/ehci-s5p.c
> @@ -173,7 +173,7 @@ static int s5p_ehci_probe(struct platform_device *pdev)
> goto fail_add_hcd;
> }
>
> - platform_set_drvdata(pdev, s5p_ehci);
> + platform_set_drvdata(pdev, hcd);
>
> return 0;
>