Re: [PATCH] usb: ehci-s5p: fix: Fix null pointer dereferencing

Vivek Gautam
2013-04-09T13:02:30Z

Hi,

On Tue, Apr 9, 2013 at 6:01 PM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> Hello.
>
>
> On 09-04-2013 13:21, Vivek Gautam wrote:
>
>> 7edb3da makes ehci-s5p as a separate driver. But,
>
>
> Please also provide the summary line of that commit in parens.

Sure, will add the commit line of that patch.

>
>
>> it raised an issue with its driver data.
>> Now that 's5p_ehci_hcd' doesn't maintain pointer to 'usb_hcd'
>> and s5p_ehci is nothing but a pointer to hcd->priv;
>> add hcd to the driver data rather than s5p_ehci.
>
>
>> This fixes issues with null pointer dereferencing in
>> s5p_ehci_shutdown(), s5p_ehci_suspend(), s5p_ehci_resume().
>
>
>> Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
>> CC: Manjunath Goudar <manjunath.goudar@linaro.org>
>> CC: Arnd Bergmann <arnd@arndb.de>
>> CC: Jingoo Han <jg1.han@samsung.com>
>
>
> WBR, Sergei

--
Thanks & Regards
Vivek