From: Tony Prisk <linux@prisktech.co.nz>
To: Axel Lin <axel.lin@ingics.com>
Cc: Linus Walleij <linus.walleij@linaro.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pinctrl: vt8500: wmt: Fix checking return value of pinctrl_register()
Date: Wed, 10 Apr 2013 07:30:36 +1200 [thread overview]
Message-ID: <51646C5C.7080108@prisktech.co.nz> (raw)
In-Reply-To: <1365523198.12439.1.camel@phoenix>
On 10/04/13 03:59, Axel Lin wrote:
> pinctrl_register() returns NULL on error.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/pinctrl/vt8500/pinctrl-wmt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/vt8500/pinctrl-wmt.c b/drivers/pinctrl/vt8500/pinctrl-wmt.c
> index 14400a7..ab63104e 100644
> --- a/drivers/pinctrl/vt8500/pinctrl-wmt.c
> +++ b/drivers/pinctrl/vt8500/pinctrl-wmt.c
> @@ -588,7 +588,7 @@ int wmt_pinctrl_probe(struct platform_device *pdev,
> data->dev = &pdev->dev;
>
> data->pctl_dev = pinctrl_register(&wmt_desc, &pdev->dev, data);
> - if (IS_ERR(data->pctl_dev)) {
> + if (!data->pctl_dev) {
> dev_err(&pdev->dev, "Failed to register pinctrl\n");
> return -EINVAL;
> }
Not sure why I missed this...
Linus,
If you're happy with this patch, I'll forward it on to arm-soc to go in
with the rest.
Regards
Tony P
next prev parent reply other threads:[~2013-04-09 19:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-09 15:59 [PATCH] pinctrl: vt8500: wmt: Fix checking return value of pinctrl_register() Axel Lin
2013-04-09 19:30 ` Tony Prisk [this message]
2013-04-15 20:29 ` Olof Johansson
2013-04-15 20:32 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51646C5C.7080108@prisktech.co.nz \
--to=linux@prisktech.co.nz \
--cc=axel.lin@ingics.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox