Re: [PATCH v3 02/22] x86, microcode: Use common get_ramdisk_image()

[Tang Chen <tangchen@cn.fujitsu.com>]

On 04/05/2013 07:46 AM, Yinghai Lu wrote:
> Use common get_ramdisk_image() to get ramdisk start phys address.
>
> We need this to get correct ramdisk adress for 64bit bzImage that
> initrd can be loaded above 4G by kexec-tools.
>
> Signed-off-by: Yinghai Lu<yinghai@kernel.org>
> Cc: Fenghua Yu<fenghua.yu@intel.com>
> Acked-by: Tejun Heo<tj@kernel.org>
> ---
>   arch/x86/kernel/microcode_intel_early.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/x86/kernel/microcode_intel_early.c b/arch/x86/kernel/microcode_intel_early.c
> index d893e8e..ea57bd8 100644
> --- a/arch/x86/kernel/microcode_intel_early.c
> +++ b/arch/x86/kernel/microcode_intel_early.c
> @@ -742,8 +742,8 @@ load_ucode_intel_bsp(void)
>   	struct boot_params *boot_params_p;
>
>   	boot_params_p = (struct boot_params *)__pa_nodebug(&boot_params);
> -	ramdisk_image = boot_params_p->hdr.ramdisk_image;
> -	ramdisk_size  = boot_params_p->hdr.ramdisk_size;
> +	ramdisk_image = get_ramdisk_image(boot_params_p);
> +	ramdisk_size  = get_ramdisk_image(boot_params_p);

Shoule be get_ramdisk_size(boot_params_p) ?

>   	initrd_start_early = ramdisk_image;
>   	initrd_end_early = initrd_start_early + ramdisk_size;
>
> @@ -752,8 +752,8 @@ load_ucode_intel_bsp(void)
>   		(unsigned long *)__pa_nodebug(&mc_saved_in_initrd),
>   		initrd_start_early, initrd_end_early,&uci);
>   #else
> -	ramdisk_image = boot_params.hdr.ramdisk_image;
> -	ramdisk_size  = boot_params.hdr.ramdisk_size;
> +	ramdisk_image = get_ramdisk_image(&boot_params);
> +	ramdisk_size  = get_ramdisk_size(&boot_params);
>   	initrd_start_early = ramdisk_image + PAGE_OFFSET;
>   	initrd_end_early = initrd_start_early + ramdisk_size;
>