Re: [PATCH] kernel: auditfilter: looping issue, memory leak if has 2 or more AUDIT_FILTERKEYs

[Chen Gang <gang.chen@asianux.com>]

  also for function audit_list_rules:
    when call audit_make_reply fails (will return NULL).
    we also need process data->buf, not only data itself.

  please help check, thanks.

  :-)

gchen.

On 2013年04月10日 18:28, Chen Gang wrote:
> 
>   also for function audit_list:
>     when call audit_make_reply fails (will return NULL).
>     we need free all its related variables instead of only kfree rull.
>       (such as call autit_free_rule)
> 
>   please help check, thanks.
> 
>   :-)
> 
> gchen.
> 
> On 2013年04月10日 18:18, Chen Gang wrote:
>>
>>
>> in another function: audit_data_to_entry:
>>
>>   a. has the same issue for case AUDIT_WATCH.
>>
>>   b. has an new issue for AUDIT_DIR:
>>        after AUDIT_DIR succeed, it will set rule->tree.
>>        next, the other case fail, then will call audit_free_rule.
>>        but audit_free_rule will not free rule->tree.
>>
>>
>>   I find them only by reading code, not test them.
>>   and I also do not know about the related features.
>>   so please help check my 2 opinions whether are correct.
>>
>>
>>   welcome any suggestion or completions.
>>
>>   thanks.
>>
>>   :-)
>>
>>
>> gchen.
>>
>>
>> On 2013年04月10日 17:52, Chen Gang wrote:
>>>
>>>   in the 'fcount' looping,
>>>     if 'new->fields[*].type" has 2 or more AUDIT_FILTERKEYs
>>>     need judge new->filterkey whether has value, or memory leak.
>>>
>>> Signed-off-by: Chen Gang <gang.chen@asianux.com>
>>> ---
>>>  kernel/auditfilter.c |    2 ++
>>>  1 files changed, 2 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/kernel/auditfilter.c b/kernel/auditfilter.c
>>> index f9fc54b..936ac79 100644
>>> --- a/kernel/auditfilter.c
>>> +++ b/kernel/auditfilter.c
>>> @@ -859,6 +859,8 @@ struct audit_entry *audit_dupe_rule(struct audit_krule *old)
>>>  						       &old->fields[i]);
>>>  			break;
>>>  		case AUDIT_FILTERKEY:
>>> +			if (new->filterkey)
>>> +				break;
>>>  			fk = kstrdup(old->filterkey, GFP_KERNEL);
>>>  			if (unlikely(!fk))
>>>  				err = -ENOMEM;
>>>
>>
>>
> 
> 


-- 
Chen Gang

Asianux Corporation