From: Chen Gang <gang.chen@asianux.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Stephen Boyd <sboyd@codeaurora.org>,
Andrew Morton <akpm@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kernel: kallsyms: parameters checking, for EXPORT_SYMBOL_GPL functions
Date: Thu, 11 Apr 2013 12:27:18 +0800 [thread overview]
Message-ID: <51663BA6.1020500@asianux.com> (raw)
In-Reply-To: <87ppy14w3u.fsf@rustcorp.com.au>
On 2013年04月11日 10:52, Rusty Russell wrote:
>>> >> Or is someone already doing this?
>>> >>
>> >
>> > really has:
>> >
>> > kernel: __wake_up_sync_key in kernel/sched/core.c.
>> > lib: *printf.
>> > mm: kfree.
> No, I mean "is someone calling these functions with NULL".
>
> Cheers,
> Rusty.
>
>
often "kfree(NULL)", that is ok. it will let caller easier using it.
also often give 0 size to snprintf, it still let caller easy using.
if we treat EXPORT functions of kallsyms as commonly used (or we want to)
I suggest to give parameter check for them.
thanks.
:-)
--
Chen Gang
Asianux Corporation
prev parent reply other threads:[~2013-04-11 4:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-09 6:00 [PATCH] kernel: kallsyms: parameters checking, for EXPORT_SYMBOL_GPL functions Chen Gang
2013-04-10 6:57 ` Rusty Russell
2013-04-10 10:56 ` Chen Gang
2013-04-11 2:52 ` Rusty Russell
2013-04-11 4:27 ` Chen Gang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51663BA6.1020500@asianux.com \
--to=gang.chen@asianux.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox