From: "Bengt Jönsson" <bengt.g.jonsson@stericsson.com>
To: Axel Lin <axel.lin@ingics.com>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>,
Lee Jones <lee.jones@linaro.org>,
Yvan FILLION <yvan.fillion@stericsson.com>,
Liam Girdwood <lgirdwood@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] regulator: ab8500: Unregister ab8500-ext regulators in probe() failure path
Date: Thu, 11 Apr 2013 08:44:09 +0200 [thread overview]
Message-ID: <51665BB9.6030101@stericsson.com> (raw)
In-Reply-To: <1365653143.17060.2.camel@phoenix>
On 04/11/2013 06:05 AM, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Looks good to me.
Acked-by: Bengt Jonsson <bengt.g.jonsson@stericsson.com>
> ---
> drivers/regulator/ab8500.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/regulator/ab8500.c b/drivers/regulator/ab8500.c
> index c200f8b..ea182d3 100644
> --- a/drivers/regulator/ab8500.c
> +++ b/drivers/regulator/ab8500.c
> @@ -3172,8 +3172,11 @@ static int ab8500_regulator_probe(struct platform_device *pdev)
> for (i = 0; i < abx500_regulator.info_size; i++) {
> err = ab8500_regulator_register(pdev, &pdata->regulator[i],
> i, NULL);
> - if (err < 0)
> + if (err < 0) {
> + if (!is_ab8505(ab8500))
> + ab8500_ext_regulator_exit(pdev);
> return err;
> + }
> }
>
> return 0;
next prev parent reply other threads:[~2013-04-11 6:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-11 4:04 [PATCH 1/2] regulator: ab8500-ext: Make the return type of ab8500_ext_regulator_exit() void Axel Lin
2013-04-11 4:05 ` [PATCH 2/2] regulator: ab8500: Unregister ab8500-ext regulators in probe() failure path Axel Lin
2013-04-11 6:44 ` Bengt Jönsson [this message]
2013-04-11 6:40 ` [PATCH 1/2] regulator: ab8500-ext: Make the return type of ab8500_ext_regulator_exit() void Bengt Jönsson
2013-04-11 16:44 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51665BB9.6030101@stericsson.com \
--to=bengt.g.jonsson@stericsson.com \
--cc=axel.lin@ingics.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=yvan.fillion@stericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox