* [PATCH] ARM64:Fix MINSIGSTKSZ and SIGSTKSZ
@ 2015-10-05 9:56 Manjeet Pawar
2015-10-05 10:58 ` Arnd Bergmann
0 siblings, 1 reply; 2+ messages in thread
From: Manjeet Pawar @ 2015-10-05 9:56 UTC (permalink / raw)
To: arnd, linux-arch, linux-api, linux-kernel
Cc: pankaj.m, Manjeet Pawar, Akhilesh Kumar, Rohit Thapliyal
MINSIGSTKSZ and SIGSTKSZ for ARM64 are not correctly set in latest kernel.
This patch fixes this issue.
This issue is reported in LTP (testcase: sigaltstack02.c).
Testcase failed when sigaltstack() called with stack size "MINSIGSTKSZ - 1"
Since in Glibc-2.22, MINSIGSTKSZ is set to 5120 but in kernel
it is set to 2048 so testcase gets failed.
Testcase Output:
sigaltstack02 1 TPASS : stgaltstack() fails, Invalid Flag value,errno:22
sigaltstack02 2 TFAIL : sigaltstack() returned 0, expected -1,errno:12
Reported Issue in Glibc Bugzilla:
https://sourceware.org/bugzilla/show_bug.cgi?id=16850
Bugfix in Glibc-2.22:
https://sourceware.org/git/gitweb.cgi?p=glibc.git;a=blob;f=sysdeps/unix/
sysv/linux/aarch64/bits/sigstack.h;h=8f2fb76e3e81734ef8a9cf9ae40daf4705
f31c35;hb=b763f6ae859ecea70a5dacb8ad45c71d5f667e2e
Signed-off-by: Akhilesh Kumar <akhilesh.k@samsung.com>
Signed-off-by: Manjeet Pawar <manjeet.p@samsung.com>
Signed-off-by: Rohit Thapliyal <r.thapliyal@samsung.com>
---
include/uapi/asm-generic/signal.h | 9 +++++++--
1 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/include/uapi/asm-generic/signal.h b/include/uapi/asm-generic/signal.h
index 9df61f1..2ffbe38 100644
--- a/include/uapi/asm-generic/signal.h
+++ b/include/uapi/asm-generic/signal.h
@@ -80,8 +80,13 @@
* SA_RESTORER 0x04000000
*/
-#define MINSIGSTKSZ 2048
-#define SIGSTKSZ 8192
+#ifdef CONFIG_ARM64
+#define MINSIGSTKSZ 5120
+#define SIGSTKSZ 16384
+#else
+#define MINSIGSTKSZ 2048
+#define SIGSTKSZ 8192
+#endif
#ifndef __ASSEMBLY__
typedef struct {
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ARM64:Fix MINSIGSTKSZ and SIGSTKSZ
2015-10-05 9:56 [PATCH] ARM64:Fix MINSIGSTKSZ and SIGSTKSZ Manjeet Pawar
@ 2015-10-05 10:58 ` Arnd Bergmann
0 siblings, 0 replies; 2+ messages in thread
From: Arnd Bergmann @ 2015-10-05 10:58 UTC (permalink / raw)
To: Manjeet Pawar
Cc: linux-arch, linux-api, linux-kernel, pankaj.m, Akhilesh Kumar,
Rohit Thapliyal
On Monday 05 October 2015 15:26:09 Manjeet Pawar wrote:
> -#define MINSIGSTKSZ 2048
> -#define SIGSTKSZ 8192
> +#ifdef CONFIG_ARM64
> +#define MINSIGSTKSZ 5120
> +#define SIGSTKSZ 16384
> +#else
> +#define MINSIGSTKSZ 2048
> +#define SIGSTKSZ 8192
> +#endif
uapi header files cannot use CONFIG_* symbols, as they are not visible
in user space.
If these have to be architecture-specific, override them in
arch/arm64/include/uapi/asm/signal.h
Arnd
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-10-05 10:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-05 9:56 [PATCH] ARM64:Fix MINSIGSTKSZ and SIGSTKSZ Manjeet Pawar
2015-10-05 10:58 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).