From: "Bengt Jönsson" <bengt.g.jonsson@stericsson.com>
To: Axel Lin <axel.lin@ingics.com>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>,
Lee Jones <lee.jones@linaro.org>,
Yvan FILLION <yvan.fillion@stericsson.com>,
Liam Girdwood <lgirdwood@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RFT][PATCH] regulator: ab8500: Fix voltage_mask for AB8505_LDO_AUDIO
Date: Fri, 12 Apr 2013 11:33:23 +0200 [thread overview]
Message-ID: <5167D4E3.5020504@stericsson.com> (raw)
In-Reply-To: <1365752005.15003.1.camel@phoenix>
On 04/12/2013 09:33 AM, Axel Lin wrote:
> The voltage_mask and voltage_shift settings of AB8505_LDO_AUDIO are not matched.
> It looks like a typo in the voltage_mask settings.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> Hi Lee and Bengt,
> I don't have the datasheet. Can you confirm if this fix is correct?
>
> Thanks,
> Axel
Yes it is correct. The voltage bits are in 0x70. Thank you!
Acked-by: Bengt Jonsson <bengt.g.jonsson@stericsson.com>
> drivers/regulator/ab8500.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/regulator/ab8500.c b/drivers/regulator/ab8500.c
> index ea182d3..b81ff04 100644
> --- a/drivers/regulator/ab8500.c
> +++ b/drivers/regulator/ab8500.c
> @@ -1130,7 +1130,7 @@ static struct ab8500_regulator_info
> .update_val = 0x02,
> .voltage_bank = 0x01,
> .voltage_reg = 0x57,
> - .voltage_mask = 0x7,
> + .voltage_mask = 0x70,
> .voltage_shift = 4,
> },
> [AB8505_LDO_ANAMIC1] = {
prev parent reply other threads:[~2013-04-12 9:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-12 7:33 [RFT][PATCH] regulator: ab8500: Fix voltage_mask for AB8505_LDO_AUDIO Axel Lin
2013-04-12 9:33 ` Bengt Jönsson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5167D4E3.5020504@stericsson.com \
--to=bengt.g.jonsson@stericsson.com \
--cc=axel.lin@ingics.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=yvan.fillion@stericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox