From: Sekhar Nori <nsekhar@ti.com>
To: Prabhakar lad <prabhakar.csengg@gmail.com>
Cc: DLOS <davinci-linux-open-source@linux.davincidsp.com>,
LMML <linux-kernel@vger.kernel.org>,
LAK <linux-arm-kernel@lists.infradead.org>,
Hans Verkuil <hans.verkuil@cisco.com>,
LKML <inux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARM: daVinci: dm644x/dm355/dm365: replace V4L2_STD_525_60/625_50 with V4L2_STD_NTSC/PAL
Date: Fri, 12 Apr 2013 16:50:25 +0530 [thread overview]
Message-ID: <5167EDF9.5070009@ti.com> (raw)
In-Reply-To: <1365764734-16515-1-git-send-email-prabhakar.csengg@gmail.com>
On 4/12/2013 4:35 PM, Prabhakar lad wrote:
> From: Lad, Prabhakar <prabhakar.csengg@gmail.com>
>
> This patch replaces V4L2_STD_525_60/625_50 with V4L2_STD_NTSC/PAL
> respectively as this are the proper video standards.
>
> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
> Reported-by: Hans Verkuil <hans.verkuil@cisco.com>
> Cc: Sekhar Nori <nsekhar@ti.com>
I assume you have tested it, some testing information would have been
good. The patch as such is OK with me. I assume this will go through
media tree for sake of dependencies.
Acked-by: Sekhar Nori <nsekhar@ti.com>
Thanks,
Sekhar
> ---
> Note:- This patch is on top of following pull
> https://patchwork.linuxtv.org/patch/17888/
>
> arch/arm/mach-davinci/board-dm355-evm.c | 4 ++--
> arch/arm/mach-davinci/board-dm365-evm.c | 4 ++--
> arch/arm/mach-davinci/board-dm644x-evm.c | 4 ++--
> 3 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/mach-davinci/board-dm355-evm.c b/arch/arm/mach-davinci/board-dm355-evm.c
> index 1043506..886481c 100644
> --- a/arch/arm/mach-davinci/board-dm355-evm.c
> +++ b/arch/arm/mach-davinci/board-dm355-evm.c
> @@ -247,7 +247,7 @@ static struct vpbe_enc_mode_info dm355evm_enc_preset_timing[] = {
> {
> .name = "ntsc",
> .timings_type = VPBE_ENC_STD,
> - .std_id = V4L2_STD_525_60,
> + .std_id = V4L2_STD_NTSC,
> .interlaced = 1,
> .xres = 720,
> .yres = 480,
> @@ -259,7 +259,7 @@ static struct vpbe_enc_mode_info dm355evm_enc_preset_timing[] = {
> {
> .name = "pal",
> .timings_type = VPBE_ENC_STD,
> - .std_id = V4L2_STD_625_50,
> + .std_id = V4L2_STD_PAL,
> .interlaced = 1,
> .xres = 720,
> .yres = 576,
> diff --git a/arch/arm/mach-davinci/board-dm365-evm.c b/arch/arm/mach-davinci/board-dm365-evm.c
> index 0518ce5..2a66743 100644
> --- a/arch/arm/mach-davinci/board-dm365-evm.c
> +++ b/arch/arm/mach-davinci/board-dm365-evm.c
> @@ -381,7 +381,7 @@ static struct vpbe_enc_mode_info dm365evm_enc_std_timing[] = {
> {
> .name = "ntsc",
> .timings_type = VPBE_ENC_STD,
> - .std_id = V4L2_STD_525_60,
> + .std_id = V4L2_STD_NTSC,
> .interlaced = 1,
> .xres = 720,
> .yres = 480,
> @@ -393,7 +393,7 @@ static struct vpbe_enc_mode_info dm365evm_enc_std_timing[] = {
> {
> .name = "pal",
> .timings_type = VPBE_ENC_STD,
> - .std_id = V4L2_STD_625_50,
> + .std_id = V4L2_STD_PAL,
> .interlaced = 1,
> .xres = 720,
> .yres = 576,
> diff --git a/arch/arm/mach-davinci/board-dm644x-evm.c b/arch/arm/mach-davinci/board-dm644x-evm.c
> index a021800..745280d 100644
> --- a/arch/arm/mach-davinci/board-dm644x-evm.c
> +++ b/arch/arm/mach-davinci/board-dm644x-evm.c
> @@ -622,7 +622,7 @@ static struct vpbe_enc_mode_info dm644xevm_enc_std_timing[] = {
> {
> .name = "ntsc",
> .timings_type = VPBE_ENC_STD,
> - .std_id = V4L2_STD_525_60,
> + .std_id = V4L2_STD_NTSC,
> .interlaced = 1,
> .xres = 720,
> .yres = 480,
> @@ -634,7 +634,7 @@ static struct vpbe_enc_mode_info dm644xevm_enc_std_timing[] = {
> {
> .name = "pal",
> .timings_type = VPBE_ENC_STD,
> - .std_id = V4L2_STD_625_50,
> + .std_id = V4L2_STD_PAL,
> .interlaced = 1,
> .xres = 720,
> .yres = 576,
>
prev parent reply other threads:[~2013-04-12 11:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-12 11:05 [PATCH] ARM: daVinci: dm644x/dm355/dm365: replace V4L2_STD_525_60/625_50 with V4L2_STD_NTSC/PAL Prabhakar lad
2013-04-12 11:20 ` Sekhar Nori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5167EDF9.5070009@ti.com \
--to=nsekhar@ti.com \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=hans.verkuil@cisco.com \
--cc=inux-kernel@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=prabhakar.csengg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox