* [PATCH RFT] regulator: ab8500: Fix voltage_shift setting for AB8540_LDO_DMIC
@ 2013-04-15 8:36 Axel Lin
2013-04-15 9:12 ` Bengt Jönsson
2013-04-15 15:56 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2013-04-15 8:36 UTC (permalink / raw)
To: Mark Brown
Cc: Bengt Jonsson, Lee Jones, Yvan FILLION, Liam Girdwood,
linux-kernel
The voltage_mask is 0xc0, thus we need to set voltage_shift = 6 to get correct
selector in get_voltage_sel and set_voltage_sel.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
Hi Bengt,
I don't have the datasheet. Can you confirm if this fix is correct?
BTW, can you also review a couple patches for ab8500 and ab8500-ext I sent a few
days ago? I ask this because now I have more patches that may depend on previous
patches.
Thanks,
Axel
drivers/regulator/ab8500.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/regulator/ab8500.c b/drivers/regulator/ab8500.c
index b81ff04..0a62ef9 100644
--- a/drivers/regulator/ab8500.c
+++ b/drivers/regulator/ab8500.c
@@ -1729,6 +1729,7 @@ static struct ab8500_regulator_info
.voltage_bank = 0x03,
.voltage_reg = 0x83,
.voltage_mask = 0xc0,
+ .voltage_shift = 6,
},
/*
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH RFT] regulator: ab8500: Fix voltage_shift setting for AB8540_LDO_DMIC
2013-04-15 8:36 [PATCH RFT] regulator: ab8500: Fix voltage_shift setting for AB8540_LDO_DMIC Axel Lin
@ 2013-04-15 9:12 ` Bengt Jönsson
2013-04-15 15:56 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Bengt Jönsson @ 2013-04-15 9:12 UTC (permalink / raw)
To: Axel Lin
Cc: Mark Brown, Lee Jones, Yvan FILLION, Liam Girdwood,
linux-kernel@vger.kernel.org
On 04/15/2013 10:36 AM, Axel Lin wrote:
> The voltage_mask is 0xc0, thus we need to set voltage_shift = 6 to get correct
> selector in get_voltage_sel and set_voltage_sel.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
The patch is correct. Voltage selection is done with 0xc0.
Acked-by: Bengt Jonsson <bengt.g.jonsson@stericsson.com>
> ---
> Hi Bengt,
> I don't have the datasheet. Can you confirm if this fix is correct?
>
> BTW, can you also review a couple patches for ab8500 and ab8500-ext I sent a few
> days ago? I ask this because now I have more patches that may depend on previous
> patches.
>
> Thanks,
> Axel
>
> drivers/regulator/ab8500.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/regulator/ab8500.c b/drivers/regulator/ab8500.c
> index b81ff04..0a62ef9 100644
> --- a/drivers/regulator/ab8500.c
> +++ b/drivers/regulator/ab8500.c
> @@ -1729,6 +1729,7 @@ static struct ab8500_regulator_info
> .voltage_bank = 0x03,
> .voltage_reg = 0x83,
> .voltage_mask = 0xc0,
> + .voltage_shift = 6,
> },
>
> /*
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH RFT] regulator: ab8500: Fix voltage_shift setting for AB8540_LDO_DMIC
2013-04-15 8:36 [PATCH RFT] regulator: ab8500: Fix voltage_shift setting for AB8540_LDO_DMIC Axel Lin
2013-04-15 9:12 ` Bengt Jönsson
@ 2013-04-15 15:56 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2013-04-15 15:56 UTC (permalink / raw)
To: Axel Lin
Cc: Bengt Jonsson, Lee Jones, Yvan FILLION, Liam Girdwood,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 208 bytes --]
On Mon, Apr 15, 2013 at 04:36:51PM +0800, Axel Lin wrote:
> The voltage_mask is 0xc0, thus we need to set voltage_shift = 6 to get correct
> selector in get_voltage_sel and set_voltage_sel.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-04-15 15:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-15 8:36 [PATCH RFT] regulator: ab8500: Fix voltage_shift setting for AB8540_LDO_DMIC Axel Lin
2013-04-15 9:12 ` Bengt Jönsson
2013-04-15 15:56 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox