public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Vitaly V. Bursov" <vitalyb@telenet.dn.ua>
To: linux-kernel@vger.kernel.org
Subject: Bonding driver has bad load balancing for forwarded traffic, 3.7+
Date: Mon, 15 Apr 2013 16:57:50 +0300	[thread overview]
Message-ID: <516C075E.30105@telenet.dn.ua> (raw)

Hello,

I have a bonding device (mode=802.3ad xmit_hash_policy=layer2+3 miimon=300) and
for kernels <3.7 forwarded IPv4 traffic distributed fine across multiple physical
links. Ethernet cards are Intel 82576 with igb driver (various versions).

3.7 and 3.8 kernels tend to fully utilize only one link and leave the others almost idling.

Replacing bond_xmit_hash_policy_* functions with older ones (3.6 kernel) looks like
resolves the issue (but I haven't tested it thoroughly).

So, I added
         printk(KERN_INFO "hash_policy: protocol = %d, skb_network_header_len = %d, %d %d\n",
             skb->protocol, skb_network_header_len(skb),
             skb_headlen(skb), skb_network_offset(skb));
to bond_xmit_hash_policy_l23() of bond_main.c

and got this:
[   65.280831] hash_policy: protocol = 8, skb_network_header_len = 0, 74 14
[   65.280835] hash_policy: protocol = 8, skb_network_header_len = 0, 74 14
[   65.280839] hash_policy: protocol = 8, skb_network_header_len = 0, 74 14
[   65.280843] hash_policy: protocol = 8, skb_network_header_len = 0, 74 14
[   65.280847] hash_policy: protocol = 8, skb_network_header_len = 0, 74 14
[   65.280851] hash_policy: protocol = 8, skb_network_header_len = 0, 74 14

It's clear that the new check condition (skb_network_header_len(skb) >= sizeof(*iph))
fails here and hash policy fallbacks to l2 balancing.

I have no idea how to fix this besides removing this check completely, any
help would be appreciated.

-- 
Thanks
Vitaly

             reply	other threads:[~2013-04-15 14:06 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-15 13:57 Vitaly V. Bursov [this message]
2013-04-16  0:37 ` Bonding driver has bad load balancing for forwarded traffic, 3.7+ Eric Dumazet
2013-04-16  3:03   ` Eric Dumazet
2013-04-16  9:01     ` Vitaly V. Bursov
2013-04-16 13:51       ` Eric Dumazet
2013-04-16 14:25         ` Eric Dumazet
2013-04-16 20:39           ` David Miller
2013-04-18 19:09     ` David Miller
2013-04-18 19:33       ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=516C075E.30105@telenet.dn.ua \
    --to=vitalyb@telenet.dn.ua \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox