* [PATCH] perf tool: fix the perf --version bug
@ 2013-04-16 5:00 Runzhen Wang
0 siblings, 0 replies; 3+ messages in thread
From: Runzhen Wang @ 2013-04-16 5:00 UTC (permalink / raw)
To: acme; +Cc: mingo, linux-kernel
From 4d629cfb265beece1aae2e3fdf603e36a321f785 Mon Sep 17 00:00:00 2001
From: Runzhen Wang <runzhen@linux.vnet.ibm.com>
Date: Mon, 15 Apr 2013 23:17:15 -0400
Subject: [PATCH] perf tool: fix the perf --version bug
The perf --version can't print the right version
information when reset it to an earlier commit.
For example, at present the version is:
# ./perf --version
perf version 3.9.rc6.gf8378f
then, I reset it to an earlier version, say v3.8-rc7
# git reset --hard v3.8-rc7
# make
However, the ./perf --version prints a wrong result:
# ./perf --version
perf version 3.9.rc6.g836dc9
Using 'git describe' instead of 'git tag' can fix this problem.
Signed-off-by: Runzhen Wang <runzhen@linux.vnet.ibm.com>
---
tools/perf/util/PERF-VERSION-GEN | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/tools/perf/util/PERF-VERSION-GEN
b/tools/perf/util/PERF-VERSION-GEN
index 055fef3..ec3dd86 100755
--- a/tools/perf/util/PERF-VERSION-GEN
+++ b/tools/perf/util/PERF-VERSION-GEN
@@ -14,9 +14,8 @@ LF='
# otherwise try to get the version from the kernel Makefile
#
if test -d ../../.git -o -f ../../.git &&
- VN=$(git tag 2>/dev/null | tail -1 | grep -E "v[0-9].[0-9]*")
+ VN=$(git describe --match 'v[0-9].[0-9]*' --abbrev=4 HEAD 2>/dev/null)
then
- VN=$(echo $VN"-g"$(git log -1 --abbrev=4 --pretty=format:"%h" HEAD))
VN=$(echo "$VN" | sed -e 's/-/./g');
else
VN=$(MAKEFLAGS= make -sC ../.. kernelversion)
--
1.7.10.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] perf tool: fix the perf --version bug
@ 2013-04-16 5:00 Runzhen Wang
2013-04-24 8:19 ` Runzhen Wang
0 siblings, 1 reply; 3+ messages in thread
From: Runzhen Wang @ 2013-04-16 5:00 UTC (permalink / raw)
To: acme; +Cc: mingo, linux-kernel, Sukadev Bhattiprolu
From 4d629cfb265beece1aae2e3fdf603e36a321f785 Mon Sep 17 00:00:00 2001
From: Runzhen Wang <runzhen@linux.vnet.ibm.com>
Date: Mon, 15 Apr 2013 23:17:15 -0400
Subject: [PATCH] perf tool: fix the perf --version bug
The perf --version can't print the right version
information when reset it to an earlier commit.
For example, at present the version is:
# ./perf --version
perf version 3.9.rc6.gf8378f
then, I reset it to an earlier version, say v3.8-rc7
# git reset --hard v3.8-rc7
# make
However, the ./perf --version prints a wrong result:
# ./perf --version
perf version 3.9.rc6.g836dc9
Using 'git describe' instead of 'git tag' can fix this problem.
Signed-off-by: Runzhen Wang <runzhen@linux.vnet.ibm.com>
---
tools/perf/util/PERF-VERSION-GEN | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/tools/perf/util/PERF-VERSION-GEN
b/tools/perf/util/PERF-VERSION-GEN
index 055fef3..ec3dd86 100755
--- a/tools/perf/util/PERF-VERSION-GEN
+++ b/tools/perf/util/PERF-VERSION-GEN
@@ -14,9 +14,8 @@ LF='
# otherwise try to get the version from the kernel Makefile
#
if test -d ../../.git -o -f ../../.git &&
- VN=$(git tag 2>/dev/null | tail -1 | grep -E "v[0-9].[0-9]*")
+ VN=$(git describe --match 'v[0-9].[0-9]*' --abbrev=4 HEAD 2>/dev/null)
then
- VN=$(echo $VN"-g"$(git log -1 --abbrev=4 --pretty=format:"%h" HEAD))
VN=$(echo "$VN" | sed -e 's/-/./g');
else
VN=$(MAKEFLAGS= make -sC ../.. kernelversion)
--
1.7.10.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] perf tool: fix the perf --version bug
2013-04-16 5:00 Runzhen Wang
@ 2013-04-24 8:19 ` Runzhen Wang
0 siblings, 0 replies; 3+ messages in thread
From: Runzhen Wang @ 2013-04-24 8:19 UTC (permalink / raw)
To: acme; +Cc: mingo, linux-kernel, Sukadev Bhattiprolu
ping~ :)
On 04/16/2013 01:00 PM, Runzhen Wang wrote:
>
> The perf --version can't print the right version
> information when reset it to an earlier commit.
>
> For example, at present the version is:
> # ./perf --version
> perf version 3.9.rc6.gf8378f
>
> then, I reset it to an earlier version tag, say v3.8-rc7
> # git reset --hard v3.8-rc7
> # make
>
> However, the ./perf --version prints a wrong result:
> # ./perf --version
> perf version 3.9.rc6.g836dc9
>
> Using 'git describe' instead of 'git tag' can fix this problem.
>
> Signed-off-by: Runzhen Wang <runzhen@linux.vnet.ibm.com>
> ---
> tools/perf/util/PERF-VERSION-GEN | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/tools/perf/util/PERF-VERSION-GEN
> b/tools/perf/util/PERF-VERSION-GEN
> index 055fef3..ec3dd86 100755
> --- a/tools/perf/util/PERF-VERSION-GEN
> +++ b/tools/perf/util/PERF-VERSION-GEN
> @@ -14,9 +14,8 @@ LF='
> # otherwise try to get the version from the kernel Makefile
> #
> if test -d ../../.git -o -f ../../.git &&
> - VN=$(git tag 2>/dev/null | tail -1 | grep -E "v[0-9].[0-9]*")
> + VN=$(git describe --match 'v[0-9].[0-9]*' --abbrev=4 HEAD 2>/dev/null)
> then
> - VN=$(echo $VN"-g"$(git log -1 --abbrev=4 --pretty=format:"%h" HEAD))
> VN=$(echo "$VN" | sed -e 's/-/./g');
> else
> VN=$(MAKEFLAGS= make -sC ../.. kernelversion)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-04-24 8:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-16 5:00 [PATCH] perf tool: fix the perf --version bug Runzhen Wang
-- strict thread matches above, loose matches on Subject: below --
2013-04-16 5:00 Runzhen Wang
2013-04-24 8:19 ` Runzhen Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox