From: "H. Peter Anvin" <hpa@zytor.com>
To: Kees Cook <keescook@chromium.org>
Cc: linux-kernel@vger.kernel.org,
kernel-hardening@lists.openwall.com,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
x86@kernel.org, Jarkko Sakkinen <jarkko.sakkinen@intel.com>,
Matthew Garrett <mjg@redhat.com>,
Matt Fleming <matt.fleming@intel.com>,
Eric Northup <digitaleric@google.com>,
Dan Rosenberg <drosenberg@vsecurity.com>,
Julien Tinnes <jln@google.com>, Will Drewry <wad@chromium.org>
Subject: Re: [PATCH 4/6] x86: relocs: build separate 32/64-bit tools
Date: Tue, 16 Apr 2013 15:21:39 -0700 [thread overview]
Message-ID: <516DCEF3.6030803@zytor.com> (raw)
In-Reply-To: <1365797627-20874-5-git-send-email-keescook@chromium.org>
On 04/12/2013 01:13 PM, Kees Cook wrote:
> Since the ELF structures and access macros change size based on 32 vs
> 64 bits, build a separate 32-bit relocs tool (for handling realmode
> and 32-bit relocations), and a 64-bit relocs tool (for handling 64-bit
> kernel relocations).
>
> Signed-off-by: Kees Cook <keescook@chromium.org>
> --
> This is ugly with the "cp". Is there some other cleaner way to trigger
> two builds with different defines from the same source file?
There definitely is.
Have simple wrapper files which do:
/* relocs_32.c */
#define ELF_BITS 32
#include "relocs.c"
/* relocs_64.c */
#define ELF_BITS 64
#include "relocs.c"
-hpa
next prev parent reply other threads:[~2013-04-16 22:22 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-12 20:13 [PATCH v2 0/6] kernel ASLR Kees Cook
2013-04-12 20:13 ` [PATCH 1/6] x86: relocs: generalize Elf structure names Kees Cook
2013-04-16 23:17 ` [tip:x86/kaslr] x86, relocs: Generalize ELF " tip-bot for Kees Cook
2013-04-12 20:13 ` [PATCH 2/6] x86: relocs: consolidate processing logic Kees Cook
2013-04-16 23:18 ` [tip:x86/kaslr] x86, relocs: Consolidate " tip-bot for Kees Cook
2013-04-12 20:13 ` [PATCH 3/6] x86: relocs: add 64-bit ELF support to relocs tool Kees Cook
2013-04-16 23:19 ` [tip:x86/kaslr] x86, relocs: Add " tip-bot for Kees Cook
2013-04-12 20:13 ` [PATCH 4/6] x86: relocs: build separate 32/64-bit tools Kees Cook
2013-04-16 22:21 ` H. Peter Anvin [this message]
2013-04-16 22:38 ` Kees Cook
2013-04-16 22:39 ` H. Peter Anvin
2013-04-16 23:20 ` [tip:x86/kaslr] x86, relocs: Build " tip-bot for Kees Cook
2013-04-16 23:22 ` [tip:x86/kaslr] x86, relocs: Refactor the relocs tool to merge 32- and 64-bit ELF tip-bot for H. Peter Anvin
2013-04-12 20:13 ` [PATCH 5/6] x86: kaslr: routines to choose random base offset Kees Cook
2013-04-14 0:11 ` Yinghai Lu
2013-04-12 20:13 ` [PATCH 6/6] x86: kaslr: relocate base offset at boot Kees Cook
2013-04-14 0:37 ` Yinghai Lu
2013-04-14 3:06 ` H. Peter Anvin
2013-04-15 21:06 ` Eric Northup
2013-04-15 21:25 ` H. Peter Anvin
2013-04-15 21:41 ` Kees Cook
2013-04-15 21:44 ` Eric Northup
2013-04-15 21:46 ` H. Peter Anvin
2013-04-15 21:59 ` Kees Cook
2013-04-16 2:31 ` H. Peter Anvin
2013-04-16 2:40 ` H. Peter Anvin
2013-04-16 16:08 ` Kees Cook
2013-04-15 22:00 ` Yinghai Lu
2013-04-15 22:07 ` Kees Cook
2013-04-15 22:38 ` Yinghai Lu
2013-04-15 22:42 ` Kees Cook
2013-04-15 22:57 ` Yinghai Lu
2013-04-16 2:34 ` H. Peter Anvin
2013-04-16 2:36 ` H. Peter Anvin
2013-04-16 2:56 ` Yinghai Lu
2013-04-16 3:02 ` H. Peter Anvin
2013-04-16 13:08 ` Ingo Molnar
2013-04-16 13:27 ` H. Peter Anvin
2013-04-16 18:08 ` [PATCH v2 0/6] kernel ASLR Kees Cook
2013-04-16 18:15 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=516DCEF3.6030803@zytor.com \
--to=hpa@zytor.com \
--cc=digitaleric@google.com \
--cc=drosenberg@vsecurity.com \
--cc=jarkko.sakkinen@intel.com \
--cc=jln@google.com \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=mingo@redhat.com \
--cc=mjg@redhat.com \
--cc=tglx@linutronix.de \
--cc=wad@chromium.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox