From: "H. Peter Anvin" <hpa@zytor.com>
To: Robin Holt <holt@sgi.com>
Cc: Ingo Molnar <mingo@kernel.org>,
"Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>,
Russ Anderson <rja@sgi.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
the arch/x86 maintainers <x86@kernel.org>
Subject: Re: [PATCH -v5 5/5] Make reboot_cpuid a kernel parameter.
Date: Wed, 17 Apr 2013 12:55:45 -0700 [thread overview]
Message-ID: <516EFE41.4000605@zytor.com> (raw)
In-Reply-To: <20130417194836.GK3658@sgi.com>
On 04/17/2013 12:48 PM, Robin Holt wrote:
>
> Did you see my response I sent this morning?
>
I did not, although I just read it.
I have a hard time seeing maintaining backwards/forwards compatibility
as "very wrong" ... it would seem like a pretty major concern. In
comparison losing the currently nonexistent /sys file seems like a
rather minor issue.
My suggestion would be to have a universal parser for reboot= and have
the arch functions fed data in already parsed form.
> I would really like to try and remove the apparently unused reboot=
> parameter from arm and unicore32 as well. Does anybody have a concern
> with that? That should make documenting slightly easier.
You have to ask the arm and unicore32 maintainers that, obviously.
>> Furthermore that word "cpuid" that you keep using, I don't think it
>> means what you think it means...
>
> If we stayed with the core_param, would you prefer reboot_processor=###
> over reboot_cpuid=###?
reboot_cpu=<n>
-hpa
next prev parent reply other threads:[~2013-04-17 19:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-17 18:43 [PATCH -v5 0/5] Shutdown from reboot_cpuid without stopping other cpus Robin Holt
2013-04-17 18:43 ` [PATCH -v5 1/5] CPU hotplug: Provide a generic helper to disable/enable CPU hotplug Robin Holt
2013-04-17 18:43 ` [PATCH -v5 2/5] Migrate shutdown/reboot to boot cpu Robin Holt
2013-04-17 18:43 ` [PATCH -v5 3/5] Move shutdown/reboot related functions to kernel/reboot.c Robin Holt
2013-04-17 18:43 ` [PATCH -v5 4/5] checkpatch.pl the new kernel/reboot.c file Robin Holt
2013-04-17 19:13 ` Robin Holt
2013-04-17 18:43 ` [PATCH -v5 5/5] Make reboot_cpuid a kernel parameter Robin Holt
2013-04-17 19:37 ` H. Peter Anvin
2013-04-17 19:48 ` Robin Holt
2013-04-17 19:55 ` H. Peter Anvin [this message]
2013-04-17 19:59 ` H. Peter Anvin
2013-04-17 20:15 ` Robin Holt
2013-04-18 0:17 ` Robin Holt
2013-04-18 0:28 ` H. Peter Anvin
2013-04-18 0:39 ` H. Peter Anvin
2013-04-18 1:25 ` Robin Holt
2013-04-18 2:04 ` Robin Holt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=516EFE41.4000605@zytor.com \
--to=hpa@zytor.com \
--cc=holt@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=rja@sgi.com \
--cc=srivatsa.bhat@linux.vnet.ibm.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox