From: Wang Shilong <wangsl-fnst@cn.fujitsu.com>
To: Wang Shilong <wangsl-fnst@cn.fujitsu.com>
Cc: yongjun_wei@trendmicro.com.cn, Wei Yongjun <weiyj.lk@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] ALSA: hda - fix error return code in patch_alc662()
Date: Thu, 18 Apr 2013 12:14:10 +0800 [thread overview]
Message-ID: <516F7312.3050002@cn.fujitsu.com> (raw)
In-Reply-To: <516F71F3.7090805@cn.fujitsu.com>
Sorry, i miss something..
Thanks,
wang
> Hello Wei,
>
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -3787,7 +3787,8 @@ static int patch_alc662(struct hda_codec *codec)
> if ((alc_get_coef0(codec) & (1 << 14)) &&
> codec->bus->pci->subsystem_vendor == 0x1025 &&
> spec->cdefine.platform_type == 1) {
> - if (alc_codec_rename(codec, "ALC272X") < 0)
>
> I don't think we should fix this problem. And your changelog is wrong!
>
> Thanks,
> Wang
> + err = alc_codec_rename(codec, "ALC272X");
> + if (err < 0)
> goto error;
> }
>
>
> --
>
next prev parent reply other threads:[~2013-04-18 4:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-18 4:09 Re:[PATCH -next] ALSA: hda - fix error return code in patch_alc662() Wang Shilong
2013-04-18 4:14 ` Wang Shilong [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-04-18 3:12 [PATCH " Wei Yongjun
2013-04-18 7:55 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=516F7312.3050002@cn.fujitsu.com \
--to=wangsl-fnst@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=weiyj.lk@gmail.com \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox