From: Markus Elfring <Markus.Elfring@web.de>
To: Masami Hiramatsu <mhiramat@kernel.org>,
linux-trace-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org, Shuah Khan <shuah@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Hari Bathini <hbathini@linux.ibm.com>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Subject: Re: [PATCH 4/8] tracing: probe-events: Log errro for exceeding the number of arguments
Date: Wed, 26 Feb 2025 17:13:17 +0100 [thread overview]
Message-ID: <516ea911-acc6-47c2-87d5-2df0a18468de@web.de> (raw)
In-Reply-To: <174055075075.4079315.10916648136898316476.stgit@mhiramat.tok.corp.google.com>
…
> +++ b/kernel/trace/trace_fprobe.c
> @@ -1201,8 +1201,11 @@ static int trace_fprobe_create_internal(int argc, const char *argv[],
> argc = new_argc;
> argv = new_argv;
> }
> - if (argc > MAX_TRACE_ARGS)
> + if (argc > MAX_TRACE_ARGS) {
> + trace_probe_log_set_index(2);
> + trace_probe_log_err(0, TOO_MANY_ARGS);
> return -E2BIG;
> + }
>
> ret = traceprobe_expand_dentry_args(argc, argv, &dbuf);
…
May a bit of exception handling code be shared by an additional jump target?
Will another goto chain become helpful here?
How do you think about to avoid a typo in the summary phrase?
Regards,
Markus
next prev parent reply other threads:[~2025-02-26 16:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-26 6:18 [PATCH 0/8] tracing: probes: Fixes and enhancing error logs Masami Hiramatsu (Google)
2025-02-26 6:18 ` [PATCH 1/8] tracing: tprobe-events: Fix a memory leak when tprobe with $retval Masami Hiramatsu (Google)
2025-02-26 15:09 ` Steven Rostedt
2025-02-26 6:18 ` [PATCH 2/8] tracing: tprobe-events: Reject invalid tracepoint name Masami Hiramatsu (Google)
2025-02-26 15:10 ` Steven Rostedt
2025-02-26 15:50 ` Markus Elfring
2025-02-26 6:19 ` [PATCH 3/8] tracing: fprobe-events: Log error for exceeding the number of entry args Masami Hiramatsu (Google)
2025-02-26 15:22 ` Steven Rostedt
2025-02-26 22:10 ` Masami Hiramatsu
2025-02-26 6:19 ` [PATCH 4/8] tracing: probe-events: Log errro for exceeding the number of arguments Masami Hiramatsu (Google)
2025-02-26 15:29 ` Steven Rostedt
2025-02-26 16:13 ` Markus Elfring [this message]
2025-02-27 0:19 ` Masami Hiramatsu
2025-02-27 10:13 ` [4/8] " Markus Elfring
2025-03-03 2:17 ` [PATCH 4/8] " Masami Hiramatsu
2025-02-26 6:19 ` [PATCH 5/8] tracing: probe-events: Remove unused MAX_ARG_BUF_LEN macro Masami Hiramatsu (Google)
2025-02-26 15:32 ` Steven Rostedt
2025-02-26 6:19 ` [PATCH 6/8] selftests/ftrace: Expand the tprobe event test to check wrong format Masami Hiramatsu (Google)
2025-02-26 6:19 ` [PATCH 7/8] selftests/ftrace: Add new syntax error test Masami Hiramatsu (Google)
2025-02-26 6:19 ` [PATCH 8/8] selftests/ftrace: Add dynamic events argument limitation test case Masami Hiramatsu (Google)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=516ea911-acc6-47c2-87d5-2df0a18468de@web.de \
--to=markus.elfring@web.de \
--cc=hbathini@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox