From: Li Zefan <lizefan@huawei.com>
To: Tejun Heo <tj@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Cgroups <cgroups@vger.kernel.org>,
Containers <containers@lists.linux-foundation.org>,
Glauber Costa <glommer@parallels.com>
Subject: [PATCH 05/10] cpuset: don't update tasks' cpumask and nodemask in an empty cpuset
Date: Fri, 19 Apr 2013 20:27:05 +0800 [thread overview]
Message-ID: <51713819.8050708@huawei.com> (raw)
In-Reply-To: <517137A7.4020605@huawei.com>
I think this was introduced unintentionally when cpuset hotplug was
made asynchronous. Fortunately it does no harm, as updating tasks'
cpumask will just return failure and there's a guarantee_online_mems()
when updating nodemask, and then the tasks will be moved to an ancestor
cpuset.
Signed-off-by: Li Zefan <lizefan@huawei.com>
---
kernel/cpuset.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/kernel/cpuset.c b/kernel/cpuset.c
index 8b0e433..2e4c5af 100644
--- a/kernel/cpuset.c
+++ b/kernel/cpuset.c
@@ -2013,7 +2013,9 @@ static void cpuset_propagate_hotplug_workfn(struct work_struct *work)
mutex_lock(&callback_mutex);
cpumask_andnot(cs->cpus_allowed, cs->cpus_allowed, &off_cpus);
mutex_unlock(&callback_mutex);
- update_tasks_cpumask(cs, NULL);
+
+ if (!cpumask_empty(cs->cpus_allowed))
+ update_tasks_cpumask(cs, NULL);
}
/* remove offline mems from @cs */
@@ -2022,7 +2024,9 @@ static void cpuset_propagate_hotplug_workfn(struct work_struct *work)
mutex_lock(&callback_mutex);
nodes_andnot(cs->mems_allowed, cs->mems_allowed, off_mems);
mutex_unlock(&callback_mutex);
- update_tasks_nodemask(cs, &tmp_mems, NULL);
+
+ if (!nodes_empty(cs->mems_allowed))
+ update_tasks_nodemask(cs, &tmp_mems, NULL);
}
is_empty = cpumask_empty(cs->cpus_allowed) ||
--
1.8.0.2
next prev parent reply other threads:[~2013-04-19 12:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-19 12:25 [PATCH 00/10] cpuset: implement sane hierarchy behaviors Li Zefan
2013-04-19 12:25 ` [PATCH 01/10] cpuset: remove redundant check in cpuset_cpus_allowed_fallback() Li Zefan
2013-04-19 12:25 ` [PATCH 02/10] cpuset: cleanup guarantee_online_{cpus|mems}() Li Zefan
2013-04-19 12:26 ` [PATCH 03/10] cpuset: remove unnecessary variable in cpuset_attach() Li Zefan
2013-04-19 12:26 ` [PATCH 04/10] cpuset: remove cpuset_test_cpumask() Li Zefan
2013-04-19 18:27 ` Tejun Heo
2013-04-19 12:27 ` Li Zefan [this message]
2013-04-19 18:36 ` [PATCH 05/10] cpuset: don't update tasks' cpumask and nodemask in an empty cpuset Tejun Heo
2013-04-20 1:06 ` Li Zefan
2013-04-21 1:42 ` Tejun Heo
2013-04-19 12:27 ` [PATCH 06/10] cpuset: re-structure update_cpumask() a bit Li Zefan
2013-04-19 12:28 ` [PATCH 07/10] cpuset: record old_mems_allowed in struct cpuset Li Zefan
2013-04-19 12:28 ` [PATCH 08/10] cpuset: introduce effective_{cpumask|nodemask}_cpuset() Li Zefan
2013-04-19 12:29 ` [PATCH 09/10] cpuset: allow to keep tasks in empty cpusets Li Zefan
2013-04-19 20:58 ` Tejun Heo
2013-04-20 1:22 ` Li Zefan
2013-04-21 1:41 ` Tejun Heo
2013-04-19 12:29 ` [PATCH 10/10] cpuset: allow to move tasks to " Li Zefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51713819.8050708@huawei.com \
--to=lizefan@huawei.com \
--cc=cgroups@vger.kernel.org \
--cc=containers@lists.linux-foundation.org \
--cc=glommer@parallels.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox