From: "zhangwei(Jovi)" <jovi.zhangwei@huawei.com>
To: David Miller <davem@davemloft.net>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 6/8] spare/sysrq: fix inconstistent help message of sysrq key
Date: Sat, 20 Apr 2013 15:41:03 +0800 [thread overview]
Message-ID: <5172468F.7070909@huawei.com> (raw)
In-Reply-To: <20130307.162724.2043364205781900432.davem@davemloft.net>
On 2013/3/8 5:27, David Miller wrote:
> From: "zhangwei(Jovi)" <jovi.zhangwei@huawei.com>
> Date: Thu, 7 Mar 2013 17:00:32 +0800
>
>> Currently help message of /proc/sysrq-trigger highlight its
>> upper-case characters, like below:
>>
>> SysRq : HELP : loglevel(0-9) reBoot Crash terminate-all-tasks(E)
>> memory-full-oom-kill(F) kill-all-tasks(I) ...
>>
>> this would confuse user trigger sysrq by upper-case character, which is
>> inconsistent with the real lower-case character registed key.
>>
>> This inconsistent help message will also lead more confused when
>> 26 upper-case letters put into use in future.
>>
>> This patch fix spare sysrq key: "global-regs(y)"
>>
>> Signed-off-by: zhangwei(Jovi) <jovi.zhangwei@huawei.com>
>
> Acked-by: David S. Miller <davem@davemloft.net>
>
David, this patch is already got your ack,
so would you please pick up this patch into your tree for next 3.10?
Thanks.
next prev parent reply other threads:[~2013-04-20 7:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-07 9:00 [PATCH 6/8] spare/sysrq: fix inconstistent help message of sysrq key zhangwei(Jovi)
2013-03-07 21:27 ` David Miller
2013-04-20 7:41 ` zhangwei(Jovi) [this message]
2013-04-20 19:49 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5172468F.7070909@huawei.com \
--to=jovi.zhangwei@huawei.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox