Re: [PATCH] of: export of_get_next_parent

Ming Lei
2013-04-21T12:12:03Z

Hi,

On Wed, Apr 10, 2013 at 5:47 PM, Ming Lei <ming.lei@canonical.com> wrote:
> The function is called by at least three drivers now:
>
> pinctrl
> mfd/vexpress
> v4l2-core
>
> The 3rd one can be built as module, so export the function to
> avoid build failure.
>
> Cc: Grant Likely <grant.likely@secretlab.ca>
> Cc: Rob Herring <rob.herring@calxeda.com>
> Cc: devicetree-discuss@lists.ozlabs.org
> Signed-off-by: Ming Lei <ming.lei@canonical.com>
> ---
> drivers/of/base.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/of/base.c b/drivers/of/base.c
> index c6443de..a2a0ddc 100644
> --- a/drivers/of/base.c
> +++ b/drivers/of/base.c
> @@ -382,6 +382,7 @@ struct device_node *of_get_next_parent(struct device_node *node)
> raw_spin_unlock_irqrestore(&devtree_lock, flags);
> return parent;
> }
> +EXPORT_SYMBOL(of_get_next_parent);

Gentle ping.

Without the patch, the below build failure is produced every time on -next tree:

Building modules, stage 2.
MODPOST 72 modules
ERROR: "of_get_next_parent" [drivers/media/v4l2-core/videodev.ko] undefined!
make[1]: *** [__modpost] Error 1
make: *** [modules] Error 2
install kernel and modules

Thanks,
--
Ming Lei