From: "zhangwei(Jovi)" <jovi.zhangwei@huawei.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 1/8] sysrq: fix inconstistent help message of sysrq key
Date: Mon, 22 Apr 2013 19:42:57 +0800 [thread overview]
Message-ID: <51752241.40701@huawei.com> (raw)
In-Reply-To: <5138F518.1080808@infradead.org>
On 2013/3/8 4:14, Randy Dunlap wrote:
> On 03/07/13 01:00, zhangwei(Jovi) wrote:
>> Currently help message of /proc/sysrq-trigger highlight its
>> upper-case characters, like below:
>>
>> SysRq : HELP : loglevel(0-9) reBoot Crash terminate-all-tasks(E)
>> memory-full-oom-kill(F) kill-all-tasks(I) ...
>>
>> this would confuse user trigger sysrq by upper-case character, which is
>> inconsistent with the real lower-case character registed key.
>>
>> This inconsistent help message will also lead more confused when
>> 26 upper-case letters put into use in future.
>>
>> This patch fix it.
>>
>> Thanks the comments from Andrew and Randy.
>>
>> Signed-off-by: zhangwei(Jovi) <jovi.zhangwei@huawei.com>
>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> Cc: Andrew Morton <akpm@linux-foundation.org>
>> Cc: Randy Dunlap <rdunlap@infradead.org>
>
> for the patch series (1-8):
> Acked-by: Randy Dunlap <rdunlap@infradead.org>
>
> Thanks.
>
Andrew, Could you pick up the other patches(2,3,4,5,7,8) into your -mm tree?
first patch was already merged by Grey.
Thanks.
prev parent reply other threads:[~2013-04-22 11:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-07 9:00 [PATCH 1/8] sysrq: fix inconstistent help message of sysrq key zhangwei(Jovi)
2013-03-07 20:14 ` Randy Dunlap
2013-04-22 11:42 ` zhangwei(Jovi) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51752241.40701@huawei.com \
--to=jovi.zhangwei@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox