* [PATCH RESEND] regulator: palmas: Fix off-by-one for ramp_delay and register value mapping
@ 2013-04-22 10:22 Axel Lin
2013-04-22 12:23 ` Laxman Dewangan
2013-04-22 12:34 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2013-04-22 10:22 UTC (permalink / raw)
To: Mark Brown; +Cc: Laxman Dewangan, Graeme Gregory, Liam Girdwood, linux-kernel
Datasheet says:
Time Step (TSTEP) selection, when changing the output voltage, the new value is
reached through successive voltage steps (if not bypassed). The equivalent
programmable slew rate of the output voltage is:
TSTEP[1:0]: 00 Jump (no slope control)
TSTEP[1:0]: 01 10mV/us
TSTEP[1:0]: 10 5mV/us (default)
TSTEP[1:0]: 11 2.5mV/us
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
This resend updates the commit log.
drivers/regulator/palmas-regulator.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/regulator/palmas-regulator.c b/drivers/regulator/palmas-regulator.c
index 8fed60c..e3e8373 100644
--- a/drivers/regulator/palmas-regulator.c
+++ b/drivers/regulator/palmas-regulator.c
@@ -447,9 +447,9 @@ static int palmas_smps_set_ramp_delay(struct regulator_dev *rdev,
if (ramp_delay <= 0)
reg = 0;
- else if (ramp_delay < 2500)
+ else if (ramp_delay <= 2500)
reg = 3;
- else if (ramp_delay < 5000)
+ else if (ramp_delay <= 5000)
reg = 2;
else
reg = 1;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH RESEND] regulator: palmas: Fix off-by-one for ramp_delay and register value mapping
2013-04-22 10:22 [PATCH RESEND] regulator: palmas: Fix off-by-one for ramp_delay and register value mapping Axel Lin
@ 2013-04-22 12:23 ` Laxman Dewangan
2013-04-22 12:34 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Laxman Dewangan @ 2013-04-22 12:23 UTC (permalink / raw)
To: Axel Lin
Cc: Mark Brown, Graeme Gregory, Liam Girdwood,
linux-kernel@vger.kernel.org
On Monday 22 April 2013 03:52 PM, Axel Lin wrote:
> Datasheet says:
> Time Step (TSTEP) selection, when changing the output voltage, the new value is
> reached through successive voltage steps (if not bypassed). The equivalent
> programmable slew rate of the output voltage is:
>
> TSTEP[1:0]: 00 Jump (no slope control)
> TSTEP[1:0]: 01 10mV/us
> TSTEP[1:0]: 10 5mV/us (default)
> TSTEP[1:0]: 11 2.5mV/us
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
Acked-by: Laxman Dewangan <ldewangan@nvidia.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH RESEND] regulator: palmas: Fix off-by-one for ramp_delay and register value mapping
2013-04-22 10:22 [PATCH RESEND] regulator: palmas: Fix off-by-one for ramp_delay and register value mapping Axel Lin
2013-04-22 12:23 ` Laxman Dewangan
@ 2013-04-22 12:34 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2013-04-22 12:34 UTC (permalink / raw)
To: Axel Lin; +Cc: Laxman Dewangan, Graeme Gregory, Liam Girdwood, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 304 bytes --]
On Mon, Apr 22, 2013 at 06:22:49PM +0800, Axel Lin wrote:
> Datasheet says:
> Time Step (TSTEP) selection, when changing the output voltage, the new value is
> reached through successive voltage steps (if not bypassed). The equivalent
> programmable slew rate of the output voltage is:
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-04-22 12:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-22 10:22 [PATCH RESEND] regulator: palmas: Fix off-by-one for ramp_delay and register value mapping Axel Lin
2013-04-22 12:23 ` Laxman Dewangan
2013-04-22 12:34 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox