* [PATCH] usb: ehci-s5p: fix: Fix null pointer dereferencing
@ 2013-04-09 9:21 Vivek Gautam
2013-04-09 10:26 ` Arnd Bergmann
2013-04-09 12:31 ` Sergei Shtylyov
0 siblings, 2 replies; 6+ messages in thread
From: Vivek Gautam @ 2013-04-09 9:21 UTC (permalink / raw)
To: linux-usb, linux-samsung-soc
Cc: linux-kernel, gregkh, stern, kgene.kim, Manjunath Goudar,
Arnd Bergmann, Jingoo Han
7edb3da makes ehci-s5p as a separate driver. But,
it raised an issue with its driver data.
Now that 's5p_ehci_hcd' doesn't maintain pointer to 'usb_hcd'
and s5p_ehci is nothing but a pointer to hcd->priv;
add hcd to the driver data rather than s5p_ehci.
This fixes issues with null pointer dereferencing in
s5p_ehci_shutdown(), s5p_ehci_suspend(), s5p_ehci_resume().
Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
CC: Manjunath Goudar <manjunath.goudar@linaro.org>
CC: Arnd Bergmann <arnd@arndb.de>
CC: Jingoo Han <jg1.han@samsung.com>
---
drivers/usb/host/ehci-s5p.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/usb/host/ehci-s5p.c b/drivers/usb/host/ehci-s5p.c
index d8cb0ca..580548a 100644
--- a/drivers/usb/host/ehci-s5p.c
+++ b/drivers/usb/host/ehci-s5p.c
@@ -173,7 +173,7 @@ static int s5p_ehci_probe(struct platform_device *pdev)
goto fail_add_hcd;
}
- platform_set_drvdata(pdev, s5p_ehci);
+ platform_set_drvdata(pdev, hcd);
return 0;
--
1.7.6.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] usb: ehci-s5p: fix: Fix null pointer dereferencing
2013-04-09 9:21 [PATCH] usb: ehci-s5p: fix: Fix null pointer dereferencing Vivek Gautam
@ 2013-04-09 10:26 ` Arnd Bergmann
2013-04-09 12:31 ` Sergei Shtylyov
1 sibling, 0 replies; 6+ messages in thread
From: Arnd Bergmann @ 2013-04-09 10:26 UTC (permalink / raw)
To: Vivek Gautam
Cc: linux-usb, linux-samsung-soc, linux-kernel, gregkh, stern,
kgene.kim, Manjunath Goudar, Jingoo Han
On Tuesday 09 April 2013, Vivek Gautam wrote:
>
> 7edb3da makes ehci-s5p as a separate driver. But,
> it raised an issue with its driver data.
> Now that 's5p_ehci_hcd' doesn't maintain pointer to 'usb_hcd'
> and s5p_ehci is nothing but a pointer to hcd->priv;
> add hcd to the driver data rather than s5p_ehci.
>
> This fixes issues with null pointer dereferencing in
> s5p_ehci_shutdown(), s5p_ehci_suspend(), s5p_ehci_resume().
Right, sorry for not spotting this during review.
> Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
> CC: Manjunath Goudar <manjunath.goudar@linaro.org>
> CC: Arnd Bergmann <arnd@arndb.de>
> CC: Jingoo Han <jg1.han@samsung.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] usb: ehci-s5p: fix: Fix null pointer dereferencing
2013-04-09 9:21 [PATCH] usb: ehci-s5p: fix: Fix null pointer dereferencing Vivek Gautam
2013-04-09 10:26 ` Arnd Bergmann
@ 2013-04-09 12:31 ` Sergei Shtylyov
2013-04-09 13:02 ` Vivek Gautam
1 sibling, 1 reply; 6+ messages in thread
From: Sergei Shtylyov @ 2013-04-09 12:31 UTC (permalink / raw)
To: Vivek Gautam
Cc: linux-usb, linux-samsung-soc, linux-kernel, gregkh, stern,
kgene.kim, Manjunath Goudar, Arnd Bergmann, Jingoo Han
Hello.
On 09-04-2013 13:21, Vivek Gautam wrote:
> 7edb3da makes ehci-s5p as a separate driver. But,
Please also provide the summary line of that commit in parens.
> it raised an issue with its driver data.
> Now that 's5p_ehci_hcd' doesn't maintain pointer to 'usb_hcd'
> and s5p_ehci is nothing but a pointer to hcd->priv;
> add hcd to the driver data rather than s5p_ehci.
> This fixes issues with null pointer dereferencing in
> s5p_ehci_shutdown(), s5p_ehci_suspend(), s5p_ehci_resume().
> Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
> CC: Manjunath Goudar <manjunath.goudar@linaro.org>
> CC: Arnd Bergmann <arnd@arndb.de>
> CC: Jingoo Han <jg1.han@samsung.com>
WBR, Sergei
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] usb: ehci-s5p: fix: Fix null pointer dereferencing
2013-04-09 12:31 ` Sergei Shtylyov
@ 2013-04-09 13:02 ` Vivek Gautam
2013-04-09 13:12 ` [PATCH v2] " Vivek Gautam
0 siblings, 1 reply; 6+ messages in thread
From: Vivek Gautam @ 2013-04-09 13:02 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: Vivek Gautam, linux-usb, linux-samsung-soc, linux-kernel, gregkh,
stern, kgene.kim, Manjunath Goudar, Arnd Bergmann, Jingoo Han
Hi,
On Tue, Apr 9, 2013 at 6:01 PM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> Hello.
>
>
> On 09-04-2013 13:21, Vivek Gautam wrote:
>
>> 7edb3da makes ehci-s5p as a separate driver. But,
>
>
> Please also provide the summary line of that commit in parens.
Sure, will add the commit line of that patch.
>
>
>> it raised an issue with its driver data.
>> Now that 's5p_ehci_hcd' doesn't maintain pointer to 'usb_hcd'
>> and s5p_ehci is nothing but a pointer to hcd->priv;
>> add hcd to the driver data rather than s5p_ehci.
>
>
>> This fixes issues with null pointer dereferencing in
>> s5p_ehci_shutdown(), s5p_ehci_suspend(), s5p_ehci_resume().
>
>
>> Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
>> CC: Manjunath Goudar <manjunath.goudar@linaro.org>
>> CC: Arnd Bergmann <arnd@arndb.de>
>> CC: Jingoo Han <jg1.han@samsung.com>
>
>
> WBR, Sergei
--
Thanks & Regards
Vivek
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] usb: ehci-s5p: fix: Fix null pointer dereferencing
2013-04-09 13:02 ` Vivek Gautam
@ 2013-04-09 13:12 ` Vivek Gautam
2013-04-22 17:16 ` Kukjin Kim
0 siblings, 1 reply; 6+ messages in thread
From: Vivek Gautam @ 2013-04-09 13:12 UTC (permalink / raw)
To: linux-usb, linux-samsung-soc
Cc: linux-kernel, gregkh, stern, kgene.kim, Manjunath Goudar,
Arnd Bergmann, Jingoo Han
7edb3da: (USB: EHCI: make ehci-s5p a separate driver)
raised an issue with ehci-s5p's driver data.
Now that 's5p_ehci_hcd' doesn't maintain pointer to 'usb_hcd'
and s5p_ehci is nothing but a pointer to hcd->priv;
add hcd to the driver data rather than s5p_ehci.
This fixes issues with null pointer dereferencing in
s5p_ehci_shutdown(), s5p_ehci_suspend(), s5p_ehci_resume().
Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
CC: Manjunath Goudar <manjunath.goudar@linaro.org>
CC: Arnd Bergmann <arnd@arndb.de>
CC: Jingoo Han <jg1.han@samsung.com>
---
Based on 'usb-next'
drivers/usb/host/ehci-s5p.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/usb/host/ehci-s5p.c b/drivers/usb/host/ehci-s5p.c
index d8cb0ca..580548a 100644
--- a/drivers/usb/host/ehci-s5p.c
+++ b/drivers/usb/host/ehci-s5p.c
@@ -173,7 +173,7 @@ static int s5p_ehci_probe(struct platform_device *pdev)
goto fail_add_hcd;
}
- platform_set_drvdata(pdev, s5p_ehci);
+ platform_set_drvdata(pdev, hcd);
return 0;
--
1.7.6.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2] usb: ehci-s5p: fix: Fix null pointer dereferencing
2013-04-09 13:12 ` [PATCH v2] " Vivek Gautam
@ 2013-04-22 17:16 ` Kukjin Kim
0 siblings, 0 replies; 6+ messages in thread
From: Kukjin Kim @ 2013-04-22 17:16 UTC (permalink / raw)
To: Vivek Gautam
Cc: linux-usb, linux-samsung-soc, linux-kernel, gregkh, stern,
kgene.kim, Manjunath Goudar, Arnd Bergmann, Jingoo Han
On 04/09/13 22:12, Vivek Gautam wrote:
> 7edb3da: (USB: EHCI: make ehci-s5p a separate driver)
> raised an issue with ehci-s5p's driver data.
> Now that 's5p_ehci_hcd' doesn't maintain pointer to 'usb_hcd'
> and s5p_ehci is nothing but a pointer to hcd->priv;
> add hcd to the driver data rather than s5p_ehci.
>
> This fixes issues with null pointer dereferencing in
> s5p_ehci_shutdown(), s5p_ehci_suspend(), s5p_ehci_resume().
>
> Signed-off-by: Vivek Gautam<gautam.vivek@samsung.com>
> CC: Manjunath Goudar<manjunath.goudar@linaro.org>
> CC: Arnd Bergmann<arnd@arndb.de>
> CC: Jingoo Han<jg1.han@samsung.com>
Acked-by: Kukjin Kim <kgene.kim@samsung.com>
Thanks.
- Kukjin
> ---
>
> Based on 'usb-next'
>
> drivers/usb/host/ehci-s5p.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/usb/host/ehci-s5p.c b/drivers/usb/host/ehci-s5p.c
> index d8cb0ca..580548a 100644
> --- a/drivers/usb/host/ehci-s5p.c
> +++ b/drivers/usb/host/ehci-s5p.c
> @@ -173,7 +173,7 @@ static int s5p_ehci_probe(struct platform_device *pdev)
> goto fail_add_hcd;
> }
>
> - platform_set_drvdata(pdev, s5p_ehci);
> + platform_set_drvdata(pdev, hcd);
>
> return 0;
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-04-22 17:16 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-09 9:21 [PATCH] usb: ehci-s5p: fix: Fix null pointer dereferencing Vivek Gautam
2013-04-09 10:26 ` Arnd Bergmann
2013-04-09 12:31 ` Sergei Shtylyov
2013-04-09 13:02 ` Vivek Gautam
2013-04-09 13:12 ` [PATCH v2] " Vivek Gautam
2013-04-22 17:16 ` Kukjin Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox