From: David Daney <ddaney@caviumnetworks.com>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: EUNBONG SONG <eunb.song@samsung.com>, <linux-mips@linux-mips.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mips: Fix invalid interrupt name in cavium-octeon
Date: Mon, 22 Apr 2013 10:33:01 -0700 [thread overview]
Message-ID: <5175744D.5020404@caviumnetworks.com> (raw)
In-Reply-To: <20130422132203.GB31642@linux-mips.org>
On 04/22/2013 06:22 AM, Ralf Baechle wrote:
> On Thu, Apr 18, 2013 at 10:50:52PM +0000, EUNBONG SONG wrote:
>
>> Change interrupt name from "RML/RSL" to "RMLRSL".
>> This fixes following warning message.
>>
>> [ 24.938793] WARNING: at fs/proc/generic.c:307 __xlate_proc_name+0x124/0x160()
>> [ 24.945926] name 'RML/RSL'
>> [ 24.948642] Modules linked in:
>> [ 24.951707] Call Trace:
>> [ 24.954157] [<ffffffff8069fe18>] dump_stack+0x8/0x34
>> [ 24.959136] [<ffffffff80290d90>] warn_slowpath_common+0x78/0xa8
>> [ 24.965056] [<ffffffff80290e60>] warn_slowpath_fmt+0x38/0x48
>> [ 24.970723] [<ffffffff803cbc8c>] __xlate_proc_name+0x124/0x160
>> [ 24.976556] [<ffffffff803cbe78>] __proc_create+0x78/0x128
>> [ 24.981963] [<ffffffff803cd044>] proc_mkdir_mode+0x2c/0x70
>> [ 24.987451] [<ffffffff80302418>] register_handler_proc+0x108/0x130
>> [ 24.993642] [<ffffffff802fd078>] __setup_irq+0x210/0x540
>> [ 24.998963] [<ffffffff802fd67c>] request_threaded_irq+0x114/0x1a0
>> [ 25.005060] [<ffffffff80262e0c>] prom_free_prom_memory+0xd4/0x588
>> [ 25.011164] [<ffffffff80691820>] free_initmem+0x10/0xc0
>> [ 25.016390] [<ffffffff80691720>] kernel_init+0x20/0x100
>> [ 25.021624] [<ffffffff8026c7e0>] ret_from_kernel_thread+0x10/0x18
>>
>> Signed-off-by: Eunbong Song <eunb.song@samsung.com>
>> ---
>> arch/mips/cavium-octeon/setup.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/mips/cavium-octeon/setup.c b/arch/mips/cavium-octeon/setup.c
>> index b0baa29..92c3150 100644
>> --- a/arch/mips/cavium-octeon/setup.c
>> +++ b/arch/mips/cavium-octeon/setup.c
>> @@ -1066,7 +1066,7 @@ void prom_free_prom_memory(void)
>>
>> /* Add an interrupt handler for general failures. */
>> if (request_irq(OCTEON_IRQ_RML, octeon_rlm_interrupt, IRQF_SHARED,
>> - "RML/RSL", octeon_rlm_interrupt)) {
>> + "RMLRSL", octeon_rlm_interrupt)) {
>> panic("Unable to request_irq(OCTEON_IRQ_RML)");
>> }
>> #endif
>
> Interesting. While your patch certainly is correct, you seem to have
> further modifications in your tree.
>
> David, Above code is wrapped by #ifdef CONFIG_CAVIUM_DECODE_RSL but doesn't
> seem to get defined anywhere. What shall we do about this?
It seems to be a vestige of the out-of-tree version. I was going to
send a patch to remove it all, and perhaps another to replace it with
something better.
David Daney
>
> Ralf
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
>
prev parent reply other threads:[~2013-04-22 17:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-18 22:50 [PATCH] mips: Fix invalid interrupt name in cavium-octeon EUNBONG SONG
2013-04-22 13:22 ` Ralf Baechle
2013-04-22 17:33 ` David Daney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5175744D.5020404@caviumnetworks.com \
--to=ddaney@caviumnetworks.com \
--cc=eunb.song@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox