From: Laxman Dewangan <ldewangan@nvidia.com>
To: Axel Lin <axel.lin@ingics.com>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>,
Liam Girdwood <lgirdwood@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] regulator: tps62360: Fix off-by-one shift for ramp_ctrl
Date: Tue, 23 Apr 2013 11:48:51 +0530 [thread overview]
Message-ID: <517627CB.1000504@nvidia.com> (raw)
In-Reply-To: <1366691753.25625.6.camel@phoenix>
On Tuesday 23 April 2013 10:05 AM, Axel Lin wrote:
> According to the datasheet[1]
>
> Register 0x06h Description: RmpCtrl (REGISTER ADDRESS: 0x06h Read/Write)
> BIT[5..7]:
> RMP[2:0] Output voltage ramp timing
> D7-D5 Slope
> 000 32mV/us
> 001 16mV/us
> 010 8mV/us
> ...
> 110 0.5mV/us
> 111 0.25mV/us
>
> Thus to get correct ramp_ctrl value, we need to right-shift 5 bits.
>
> [1] http://www.ti.com/lit/ds/symlink/tps62360.pdf
>
Checked with my latest and it is correct.
Acked-by: Laxman Dewangan <ldewangan@nvidia.com>
next prev parent reply other threads:[~2013-04-23 6:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-23 4:35 [PATCH] regulator: tps62360: Fix off-by-one shift for ramp_ctrl Axel Lin
2013-04-23 6:18 ` Laxman Dewangan [this message]
2013-04-23 10:26 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=517627CB.1000504@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=axel.lin@ingics.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox