From: Matt Fleming <matt.fleming@intel.com>
To: Josh Boyer <jwboyer@redhat.com>
Cc: Matthew Garrett <matthew.garrett@nebula.com>,
"linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] efi: Check EFI revision in setup_efi_vars
Date: Wed, 24 Apr 2013 16:20:04 +0100 [thread overview]
Message-ID: <5177F824.3080506@intel.com> (raw)
In-Reply-To: <20130424151652.GD15272@hansolo.jdub.homelinux.org>
On 24/04/13 16:16, Josh Boyer wrote:
> We need to check the runtime sys_table for the EFI version the firmware
> specifies instead of just checking for a NULL QueryVariableInfo. Older
> implementations of EFI don't have QueryVariableInfo but the runtime is
> a smaller structure, so the pointer to it may be pointing off into garbage.
>
> This is apparently the case with several Apple firmwares that support EFI
> 1.10, and the current check causes them to no longer boot. Fix based on
> a suggestion from Matthew Garrett.
>
> Signed-off-by: Josh Boyer <jwboyer@redhat.com>
> ---
> v2: Drop the unnecessary NULL check
>
> arch/x86/boot/compressed/eboot.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks, applied.
prev parent reply other threads:[~2013-04-24 15:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-24 14:37 [PATCH] efi: Check EFI revision in setup_efi_vars Josh Boyer
2013-04-24 14:44 ` Matt Fleming
2013-04-24 14:54 ` Josh Boyer
2013-04-24 14:57 ` Matt Fleming
2013-04-24 15:01 ` Matthew Garrett
2013-04-24 15:16 ` [PATCH v2] " Josh Boyer
2013-04-24 15:20 ` Matt Fleming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5177F824.3080506@intel.com \
--to=matt.fleming@intel.com \
--cc=jwboyer@redhat.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.garrett@nebula.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox