From: Chris Metcalf <cmetcalf@tilera.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arch/tile: Fix syscall return value passed to tracepoint
Date: Wed, 24 Apr 2013 16:45:31 -0400 [thread overview]
Message-ID: <5178446B.4050901@tilera.com> (raw)
In-Reply-To: <1366210882-27109-1-git-send-email-simon.marchi@polymtl.ca>
On 4/17/2013 11:01 AM, Simon Marchi wrote:
> Currently the syscall number is passed, but it should be the return
> value, which is kept in r0.
>
> Signed-off-by: Simon Marchi <simon.marchi@polymtl.ca>
> ---
> This patch applies on Chris Metcalf's tree:
> http://git.kernel.org/cgit/linux/kernel/git/cmetcalf/linux-tile.git
>
> arch/tile/include/uapi/arch/abi.h | 2 ++
> arch/tile/kernel/ptrace.c | 2 +-
> 2 files changed, 3 insertions(+), 1 deletions(-)
Accepted into the tile tree, but just using [0] instead of adding a new <arch/abi.h> #define. The reason is that the compiler actually uses r0..r9 inclusive for return values, e.g. returning small structs, so I'm reluctant to call out r0 for a special name.
--
Chris Metcalf, Tilera Corp.
http://www.tilera.com
prev parent reply other threads:[~2013-04-24 20:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-17 15:01 [PATCH] arch/tile: Fix syscall return value passed to tracepoint Simon Marchi
2013-04-24 20:45 ` Chris Metcalf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5178446B.4050901@tilera.com \
--to=cmetcalf@tilera.com \
--cc=linux-kernel@vger.kernel.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox