From: Huang Shijie <b32955@freescale.com>
To: Brian Norris <computersforpeace@gmail.com>
Cc: <dwmw2@infradead.org>, <dedekind1@gmail.com>,
<linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V3 4/9] mtd: get the ECC info from the Extended Parameter Page
Date: Thu, 25 Apr 2013 14:38:41 +0800 [thread overview]
Message-ID: <5178CF71.8010302@freescale.com> (raw)
In-Reply-To: <CAN8TOE-yrawXsZzUX-SfNq+COJsRfPNJZJiJBZ=e7uavBPis5g@mail.gmail.com>
于 2013年04月25日 14:20, Brian Norris 写道:
> No, you cannot do this. Some drivers will provide their own cmdfunc,
> so nand_command_lp() is unexpected for those drivers.
ok. got it.
> Your problem seems, instead, that you are executing this function too
> early, before nand_flash_get_type() is able to assign
yes. This is just the case i meet.
> nand_command_lp() to be your cmdfunc. You might just want to call this
> function after the following lines in nand_flash_get_type():
>
> /* Do not replace user supplied command function! */
> if (mtd->writesize> 512&& chip->cmdfunc == nand_command)
> chip->cmdfunc = nand_command_lp;
>
I will send a fix patch about this patch.
thanks
Huang Shijie
next prev parent reply other threads:[~2013-04-25 6:37 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-23 8:54 [PATCH V3 0/9] mtd: add datasheet's ECC information to nand_chip{} Huang Shijie
2013-04-23 8:54 ` [PATCH V3 1/9] mtd: add more comment for ecc_strength/ecc_size Huang Shijie
2013-04-25 6:32 ` Brian Norris
2013-04-25 6:39 ` Huang Shijie
2013-04-25 6:40 ` Huang Shijie
2013-04-23 8:54 ` [PATCH V3 2/9] mtd: add data structures for Extended Parameter Page Huang Shijie
2013-04-23 8:54 ` [PATCH V3 3/9] mtd: add a helper to get the supported features for ONFI nand Huang Shijie
2013-04-23 8:54 ` [PATCH V3 4/9] mtd: get the ECC info from the Extended Parameter Page Huang Shijie
2013-04-25 6:20 ` Brian Norris
2013-04-25 6:38 ` Huang Shijie [this message]
2013-04-23 8:54 ` [PATCH V3 5/9] mtd: replace the hardcode with the onfi_feature() Huang Shijie
2013-04-23 8:54 ` [PATCH V3 6/9] mtd: add a new field for ecc info in the nand_flash_dev{} Huang Shijie
2013-04-25 6:57 ` Brian Norris
2013-04-25 8:56 ` Huang Shijie
2013-04-26 6:15 ` Brian Norris
2013-04-26 6:24 ` Huang Shijie
2013-04-23 8:54 ` [PATCH V3 7/9] mtd: parse out the ECC info for the full-id nand chips Huang Shijie
2013-04-23 8:54 ` [PATCH V3 8/9] mtd: add the ecc info for some " Huang Shijie
2013-04-23 8:54 ` [PATCH V3 9/9] mtd: gpmi: set the BCH's geometry with the ecc info Huang Shijie
2013-04-25 6:40 ` [PATCH V3 0/9] mtd: add datasheet's ECC information to nand_chip{} Brian Norris
2013-04-25 6:45 ` Huang Shijie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5178CF71.8010302@freescale.com \
--to=b32955@freescale.com \
--cc=computersforpeace@gmail.com \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox