From: "H. Peter Anvin" <hpa@zytor.com>
To: "Ted Ts'o" <tytso@mit.edu>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"H. Peter Anvin" <hpa@linux.intel.com>,
stable <stable@vger.kernel.org>
Subject: Re: [PATCH 2/2] random: Account for entropy loss due to overwrites
Date: Thu, 25 Apr 2013 08:19:44 -0700 [thread overview]
Message-ID: <51794990.6050405@zytor.com> (raw)
In-Reply-To: <517942AB.1010201@zytor.com>
On this subject, I assume this is a bug?
871
872 if (r->entropy_count / 8 >= nbytes + reserved)
873 r->entropy_count -= nbytes*8;
874 else
875 r->entropy_count = reserved;
876
[specifically the use of "reserved" as opposed to "reserved*8" on line 875?]
-hpa
prev parent reply other threads:[~2013-04-25 15:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-24 4:26 [PATCH v2 0/2] random: Account for entropy loss due to overwrites H. Peter Anvin
2013-04-24 4:26 ` [PATCH 1/2] random: Statically compute poolbitshift, poolbytes, poolbits H. Peter Anvin
2013-04-24 4:26 ` [PATCH 2/2] random: Account for entropy loss due to overwrites H. Peter Anvin
2013-04-25 14:38 ` Linus Torvalds
2013-04-25 14:44 ` H. Peter Anvin
2013-04-25 14:50 ` H. Peter Anvin
2013-04-25 15:19 ` H. Peter Anvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51794990.6050405@zytor.com \
--to=hpa@zytor.com \
--cc=hpa@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox