RE: [PATCH 05/21] atm: he: use mdelay instead of large udelay constants

David Laight
2013-04-26T08:23:49Z

> ARM cannot handle udelay for more than 2 miliseconds, so we
> should use mdelay instead for those.
...
> @@ -1055,7 +1055,7 @@ static int he_start(struct atm_dev *dev)
> he_writel(he_dev, 0x0, RESET_CNTL);
> he_writel(he_dev, 0xff, RESET_CNTL);
>
> - udelay(16*1000); /* 16 ms */
> + mdelay(16); /* 16 ms */
> status = he_readl(he_dev, RESET_CNTL);

16ms seems a long time to spin.
I'd have thought a sleep would be more appropriate.
Since this looks like timing a hardware reset pulse
it can't matter if it is somewhat longer.

David