public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Chen Gang <gang.chen@asianux.com>
To: Michael Neuling <mikey@neuling.org>
Cc: Mike Qiu <qiudayu@linux.vnet.ibm.com>,
	Paul Mackerras <paulus@samba.org>,
	Michael Ellerman <michael@ellerman.id.au>,
	linuxppc-dev@lists.ozlabs.org, sfr@canb.auug.org.au,
	matt@ozlabs.org, linux-kernel@vger.kernel.org,
	"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Subject: Re: [PATCH v2] PowerPC: kernel: compiling issue, make additional room in exception vector area
Date: Fri, 26 Apr 2013 09:18:16 +0800	[thread overview]
Message-ID: <5179D5D8.8080102@asianux.com> (raw)
In-Reply-To: <5179D302.9060203@asianux.com>

On 2013年04月26日 09:06, Chen Gang wrote:
>> CFAR is the Come From Register.  It saves the location of the last
>> > branch and is hence overwritten by any branch.
>> > 
> Do we process it just like others done (e.g. 0x300, 0xe00, 0xe20 ...) ?
> 	. = 0x900
> 	.globl decrementer_pSeries
> decrementer_pSeries:
>  	HMT_MEDIUM_PPR_DISCARD
> 	SET_SCRATCH0(r13)
> 	b decrementer_pSeries_0
> 
> 	...
> 
> 

Such as the fix below, is it OK (just like 0x300 or 0x200 has done) ?

Please check, thanks.

---------------------------diff begin-------------------------------------

diff --git a/arch/powerpc/kernel/exceptions-64s.S b/arch/powerpc/kernel/exceptions-64s.S
index e789ee7..a0a5ff2 100644
--- a/arch/powerpc/kernel/exceptions-64s.S
+++ b/arch/powerpc/kernel/exceptions-64s.S
@@ -254,7 +254,14 @@ hardware_interrupt_hv:
 	STD_EXCEPTION_PSERIES(0x800, 0x800, fp_unavailable)
 	KVM_HANDLER_PR(PACA_EXGEN, EXC_STD, 0x800)
 
-	MASKABLE_EXCEPTION_PSERIES(0x900, 0x900, decrementer)
+	. = 0x900
+	.globl decrementer_pSeries
+decrementer_pSeries:
+	HMT_MEDIUM_PPR_DISCARD
+	SET_SCRATCH0(r13)		/* save r13 */
+	EXCEPTION_PROLOG_0(PACA_EXGEN)
+	b	decrementer_pSeries_0
+
 	STD_EXCEPTION_HV(0x980, 0x982, hdecrementer)
 
 	MASKABLE_EXCEPTION_PSERIES(0xa00, 0xa00, doorbell_super)
@@ -536,6 +543,12 @@ ALT_FTR_SECTION_END_IFCLR(CPU_FTR_ARCH_206)
 #endif
 
 	.align	7
+	/* moved from 0x900 */
+decrementer_pSeries_0:
+	EXCEPTION_PROLOG_1(PACA_EXGEN, SOFTEN_TEST_PR, 0x900)
+	EXCEPTION_PROLOG_PSERIES_1(decrementer_common, EXC_STD)
+
+	.align	7
 	/* moved from 0xe00 */
 	STD_EXCEPTION_HV_OOL(0xe02, h_data_storage)
 	KVM_HANDLER_SKIP(PACA_EXGEN, EXC_HV, 0xe02)

---------------------------diff end---------------------------------------

-- 
Chen Gang

Asianux Corporation

  reply	other threads:[~2013-04-26  1:19 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-24  8:22 "attempt to move .org backwards" still show up Mike Qiu
2013-04-24  8:31 ` Michael Ellerman
2013-04-24  8:35   ` Mike Qiu
2013-04-24 10:37     ` Michael Neuling
2013-04-24 12:47       ` Mike
2013-04-25  1:05         ` Chen Gang
2013-04-25  4:05           ` Mike Qiu
2013-04-25  5:36             ` Chen Gang
2013-04-25  7:23               ` Chen Gang
2013-04-25  6:25             ` Paul Mackerras
2013-04-25 11:16               ` Chen Gang
2013-04-26  1:58                 ` Mike Qiu
2013-04-26  2:05                   ` Chen Gang
2013-04-25 11:51               ` [PATCH v2] PowerPC: kernel: compiling issue, make additional room in exception vector area Chen Gang
2013-04-25 11:58                 ` Chen Gang
2013-04-25 23:16                 ` Michael Neuling
2013-04-26  1:06                   ` Chen Gang
2013-04-26  1:18                     ` Chen Gang [this message]
2013-04-26  1:36                       ` Chen Gang
2013-04-26  2:03                         ` Mike Qiu
2013-04-26  2:06                           ` Chen Gang
2013-04-26  3:08                             ` Mike Qiu
2013-04-26  3:25                               ` Chen Gang
2013-04-26  3:42                                 ` Chen Gang
2013-04-26  3:54                                   ` Mike Qiu
2013-04-27  9:28                                     ` Chen Gang F T
2013-04-27  9:32                                       ` Mike Qiu
2013-04-27  9:33                                         ` Chen Gang
2013-04-26  3:19               ` "attempt to move .org backwards" still show up Mike Qiu
2013-04-25  8:18             ` [PATCH] PowerPC: kernel: compiling issue, make additional room in exception vector area Chen Gang
2013-04-25  8:21               ` Chen Gang
2013-04-25  8:24                 ` Mike Qiu
2013-04-25  9:00               ` Michael Neuling
2013-04-25  9:05                 ` Chen Gang
2013-04-25  9:30                   ` Chen Gang
2013-04-24  8:36   ` "attempt to move .org backwards" still show up Mike Qiu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5179D5D8.8080102@asianux.com \
    --to=gang.chen@asianux.com \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=matt@ozlabs.org \
    --cc=michael@ellerman.id.au \
    --cc=mikey@neuling.org \
    --cc=paulus@samba.org \
    --cc=qiudayu@linux.vnet.ibm.com \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox