From: Tang Chen <tangchen@cn.fujitsu.com>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
"H. Peter Anvin" <hpa@zytor.com>,
Andrew Morton <akpm@linux-foundation.org>,
Tejun Heo <tj@kernel.org>, Thomas Renninger <trenn@suse.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 00/22] x86, ACPI, numa: Parse numa info early
Date: Fri, 26 Apr 2013 16:58:41 +0800 [thread overview]
Message-ID: <517A41C1.1010208@cn.fujitsu.com> (raw)
In-Reply-To: <1365728168-32067-1-git-send-email-yinghai@kernel.org>
Hi Yinghai,
It has been a long time since this patch-set was sent. I think we need to
do something to push it.
In my understanding, this patch-set did 2 things.
1. Parse numa info earlier, some improvements for
ACPI_INITRD_TABLE_OVERRIDE.
(patch1 ~ patch20)
2. Allocate pagetable in local node at boot time. (patch21 ~ patch22)
As you know, the current implement of memory hot-remove is not based on
putting pagetable in local node. If we put pagetable in local node at boot
time, the memory hot-remove won't be able to work as before.
I agree that this should be fixed. But we have the following two reasons to
push "Parse numa info earlier" part first, and improve the performance
later.
1. patch21 and patch22 only affect the performance, not the functionality.
I think we can make memory hot-remove work in the kernel, and than
improve
the performance.
2. Besides putting pagetable in local node at boot time, there are many
other
things need to do. I'm working on improving hot-add code to allocate
pagetable
and vmemmap in local node, and improving hot-remove code to support
freeing
this kind of memory.
So in order to push this patch-set and memory hot-remove functionality,
shall we divide this patch-set into 2 steps:
1. Push patch1 ~ patch20, and I'll push the remaining memory hot-remove
work together.
2. Merge your "putting pagetable in local node" work with the
performance improvement
work I'm doing, and improve the performance.
How do you think ?
BTW, I'm testing your patch-set, and will give a result next week.
I can also help to rebase it if you like.
Thanks. :)
next prev parent reply other threads:[~2013-04-26 8:55 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-12 0:55 [PATCH v4 00/22] x86, ACPI, numa: Parse numa info early Yinghai Lu
2013-04-12 0:55 ` [PATCH v4 01/22] x86: Change get_ramdisk_image() to global Yinghai Lu
2013-04-12 0:55 ` [PATCH v4 02/22] x86, microcode: Use common get_ramdisk_image() Yinghai Lu
2013-04-12 0:55 ` [PATCH v4 03/22] x86, ACPI, mm: Kill max_low_pfn_mapped Yinghai Lu
2013-06-05 8:36 ` Tang Chen
2013-04-12 0:55 ` [PATCH v4 04/22] x86, ACPI: Search buffer above 4G in second try for acpi override tables Yinghai Lu
2013-04-12 0:55 ` [PATCH v4 05/22] x86, ACPI: Increase override tables number limit Yinghai Lu
2013-04-12 0:55 ` [PATCH v4 06/22] x86, ACPI: Split acpi_initrd_override to find/copy two functions Yinghai Lu
2013-04-12 0:55 ` [PATCH v4 07/22] x86, ACPI: Store override acpi tables phys addr in cpio files info array Yinghai Lu
2013-04-12 0:55 ` [PATCH v4 08/22] x86, ACPI: Make acpi_initrd_override_find work with 32bit flat mode Yinghai Lu
2013-04-12 0:55 ` [PATCH v4 09/22] x86, ACPI: Find acpi tables in initrd early from head_32.S/head64.c Yinghai Lu
2013-04-12 0:55 ` [PATCH v4 10/22] x86, mm, numa: Move two functions calling on successful path later Yinghai Lu
2013-04-12 0:55 ` [PATCH v4 11/22] x86, mm, numa: Call numa_meminfo_cover_memory() checking early Yinghai Lu
2013-04-12 0:55 ` [PATCH v4 12/22] x86, mm, numa: Move node_map_pfn alignment() to x86 Yinghai Lu
2013-04-12 0:55 ` [PATCH v4 13/22] x86, mm, numa: Use numa_meminfo to check node_map_pfn alignment Yinghai Lu
2013-04-12 0:56 ` [PATCH v4 14/22] x86, mm, numa: Set memblock nid later Yinghai Lu
2013-04-12 0:56 ` [PATCH v4 15/22] x86, mm, numa: Move node_possible_map setting later Yinghai Lu
2013-04-12 0:56 ` [PATCH v4 16/22] x86, mm, numa: Move emulation handling down Yinghai Lu
2013-04-12 0:56 ` [PATCH v4 17/22] x86, ACPI, numa, ia64: split SLIT handling out Yinghai Lu
2013-04-12 0:56 ` [PATCH v4 18/22] x86, mm, numa: Add early_initmem_init() stub Yinghai Lu
2013-04-12 0:56 ` [PATCH v4 19/22] x86, mm: Parse numa info early Yinghai Lu
2013-04-12 0:56 ` [PATCH v4 20/22] x86, mm: Add comments for step_size shift Yinghai Lu
2013-04-12 0:56 ` [PATCH v4 21/22] x86, mm: Make init_mem_mapping be able to be called several times Yinghai Lu
2013-04-12 0:56 ` [PATCH v4 22/22] x86, mm, numa: Put pagetable on local node ram for 64bit Yinghai Lu
2013-04-26 8:58 ` Tang Chen [this message]
2013-04-30 7:21 ` [PATCH v4 00/22] x86, ACPI, numa: Parse numa info early Tang Chen
2013-05-06 9:49 ` Tang Chen
2013-05-09 8:54 ` Tang Chen
2013-05-09 18:24 ` Yinghai Lu
2013-05-13 2:59 ` Tang Chen
2013-05-14 9:06 ` Tang Chen
2013-05-22 5:14 ` Tang Chen
2013-05-22 5:18 ` H. Peter Anvin
2013-06-03 6:01 ` Tang Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=517A41C1.1010208@cn.fujitsu.com \
--to=tangchen@cn.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=trenn@suse.de \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox