From: Matt Fleming <matt.fleming@intel.com>
To: Seiji Aguchi <seiji.aguchi@hds.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"mingo@kernel.org" <mingo@kernel.org>,
"hpa@zytor.com" <hpa@zytor.com>,
"mjg59@srcf.ucam.org" <mjg59@srcf.ucam.org>,
"tony.luck@intel.com" <tony.luck@intel.com>,
"jk@ozlabs.org" <jk@ozlabs.org>, "teg@jklm.no" <teg@jklm.no>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"mikew@google.com" <mikew@google.com>,
"linux-tip-commits@vger.kernel.org"
<linux-tip-commits@vger.kernel.org>
Subject: Re: [tip:x86/efi2] efivars: efivar_entry API
Date: Fri, 26 Apr 2013 10:55:54 +0100 [thread overview]
Message-ID: <517A4F2A.4080906@intel.com> (raw)
In-Reply-To: <A5ED84D3BB3A384992CBB9C77DEDA4D41AFCC9D0@USINDEM103.corp.hds.com>
On 24/04/13 00:55, Seiji Aguchi wrote:
> Hi,
>
> I tested a current tip tree to check if the new API works.
> But pstore_erase() doesn't work...
> I'm checking the source code right now.
>
> Seiji
[...]
> Call Trace:
> [<ffffffff8143001f>] efi_pstore_erase+0xdf/0x130
> [<ffffffff81200038>] ? cap_socket_create+0x8/0x10
> [<ffffffff811ea491>] pstore_unlink+0x41/0x60
> [<ffffffff811741ff>] vfs_unlink+0x9f/0x110
> [<ffffffff8117813b>] do_unlinkat+0x18b/0x280
> [<ffffffff81178472>] sys_unlinkat+0x22/0x40
> [<ffffffff81542402>] system_call_fastpath+0x16/0x1b
Does this patch fix things?
---
diff --git a/drivers/firmware/efi/efi-pstore.c b/drivers/firmware/efi/efi-pstore.c
index 47ae712..b820593 100644
--- a/drivers/firmware/efi/efi-pstore.c
+++ b/drivers/firmware/efi/efi-pstore.c
@@ -173,7 +173,7 @@ static int efi_pstore_erase(enum pstore_type_id type, u64 id, int count,
struct timespec time, struct pstore_info *psi)
{
struct pstore_erase_data edata;
- struct efivar_entry *entry;
+ struct efivar_entry *entry = NULL;
char name[DUMP_NAME_LEN];
efi_char16_t efi_name[DUMP_NAME_LEN];
int found, i;
next prev parent reply other threads:[~2013-04-26 9:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <tip-e14ab23dde12b80db4c94b684a2e485b72b16af3@git.kernel.org>
2013-04-23 23:55 ` [tip:x86/efi2] efivars: efivar_entry API Seiji Aguchi
2013-04-26 9:55 ` Matt Fleming [this message]
2013-04-26 14:25 ` Seiji Aguchi
2013-04-26 14:55 ` Matt Fleming
2013-04-26 15:05 ` Seiji Aguchi
2013-04-26 14:28 ` Seiji Aguchi
2013-04-26 14:35 ` Fleming, Matt
2013-04-26 14:37 ` Seiji Aguchi
2013-04-26 15:43 ` Seiji Aguchi
2013-04-30 11:27 ` Matt Fleming
2013-04-30 14:53 ` Seiji Aguchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=517A4F2A.4080906@intel.com \
--to=matt.fleming@intel.com \
--cc=hpa@zytor.com \
--cc=jk@ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mikew@google.com \
--cc=mingo@kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=seiji.aguchi@hds.com \
--cc=teg@jklm.no \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox