From: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
To: Marek Belisko <marek.belisko@gmail.com>
Cc: grant.likely@secretlab.ca, rob.herring@calxeda.com,
rob@landley.net, alsa-devel@alsa-project.org,
Michal Bachraty <michal.bachraty@streamunlimited.com>,
linux-doc@vger.kernel.org, tiwai@suse.de,
devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org, broonie@kernel.org,
Marek Belisko <marek.belisko@streamunlimited.com>,
perex@perex.cz
Subject: Re: [PATCH v2 2/3] ASoC: spdif_transmitter: Add DT support.
Date: Fri, 26 Apr 2013 21:24:26 +0200 [thread overview]
Message-ID: <517AD46A.2020402@gmail.com> (raw)
In-Reply-To: <1366895594-19596-3-git-send-email-marek.belisko@streamunlimited.com>
On 04/25/2013 03:13 PM, Marek Belisko wrote:
> Add devicetree support for this dummy audio soc driver.
>
> Signed-off-by: Michal Bachraty<michal.bachraty@streamunlimited.com>
> Signed-off-by: Marek Belisko<marek.belisko@streamunlimited.com>
> ---
> .../bindings/sound/spdif-transmitter.txt | 10 ++++++++++
> sound/soc/codecs/spdif_transmitter.c | 10 ++++++++++
> 2 files changed, 20 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/sound/spdif-transmitter.txt
>
> diff --git a/Documentation/devicetree/bindings/sound/spdif-transmitter.txt b/Documentation/devicetree/bindings/sound/spdif-transmitter.txt
> new file mode 100644
> index 0000000..55a8584
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/spdif-transmitter.txt
> @@ -0,0 +1,10 @@
> +Device-Tree bindings for dummy spdif transmitter
> +
> +Required properties:
> + - compatible: should be "linux,spdif-dit".
Marek,
I remember Daniel commenting on the name already, but
what about "spdif-transmitter" and "spdif-receiver" respectively?
That is very generic and should allow to remove "linux," prefix.
And there is a lot of drivers using more informative compatible
strings compared to the driver name.
Sebastian
next prev parent reply other threads:[~2013-04-26 19:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-25 13:13 [PATCH v2 0/3] ASoC: Add devicetree support for spdif dummy codecs Marek Belisko
2013-04-25 13:13 ` [PATCH v2 1/3] ASoC: spdif_transceiver: Change driver filename to spdif_transmitter.c Marek Belisko
2013-04-25 13:13 ` [PATCH v2 2/3] ASoC: spdif_transmitter: Add DT support Marek Belisko
2013-04-26 19:24 ` Sebastian Hesselbarth [this message]
2013-04-29 12:16 ` Marek Belisko
2013-04-29 20:10 ` Mark Brown
2013-04-25 13:13 ` [PATCH v2 3/3] ASoC: spdif_receiver: " Marek Belisko
2013-04-30 18:43 ` [PATCH v2 0/3] ASoC: Add devicetree support for spdif dummy codecs Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=517AD46A.2020402@gmail.com \
--to=sebastian.hesselbarth@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marek.belisko@gmail.com \
--cc=marek.belisko@streamunlimited.com \
--cc=michal.bachraty@streamunlimited.com \
--cc=perex@perex.cz \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox