public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: KOSAKI Motohiro <kosaki.motohiro@gmail.com>
To: Olivier Langlois <olivier@trillion01.com>
Cc: KOSAKI Motohiro <kosaki.motohiro@gmail.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	schwidefsky@de.ibm.com, Steven Rostedt <rostedt@goodmis.org>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/3] process cputimer is moving faster than its corresponding clock
Date: Mon, 29 Apr 2013 14:31:13 -0400	[thread overview]
Message-ID: <517EBC71.4070709@gmail.com> (raw)
In-Reply-To: <1367259631.8833.27.camel@Wailaba2>

(4/29/13 2:20 PM), Olivier Langlois wrote:
> 
>>
>>>> I'm confused. glibc's rt/tst-cputimer1 doesn't have thread exiting code. I have
>>>> no seen any issue in this accounting.
>>>
>>> glibc launch a helper thread to receive timer signal and will also
>>> create a new thread upon signal reception when a timer is created with
>>> sigev_notify = SIGEV_THREAD;
>>>
>>> please see:
>>>
>>> glibc-2.17/nptl/sysdeps/unix/sysv/linux/timer_create.c
>>> glibc-2.17/nptl/sysdeps/unix/sysv/linux/timer_routines.c
>>
>> I know. I taled thread exiting. not thread creating. And, as far as I can see, only test sig1 can fail,
>> not thr[12].
>>
> Apart from glibc helper thread, the threads created for handling timer
> firing all do exit immediatly as soon as user callback returns.

And, libc ensure its exiting finished before starting actual tests. Why such thread exiting
affect timers code? It shouldn't. becuase signal.cputimer is initialized timer_settime().
The initialization is incorrect, we should fix initialization.


> I count 12 thread exits during tst-cputimer1 execution. The errors do
> add up hence you're more likely to see errors after 2.5 sec and up from
> start of execution. I have seen sig1, thr[12] fails. I see no reason why
> one could not fail.





  reply	other threads:[~2013-04-29 18:37 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-05 17:59 [PATCH] process cputimer is moving faster than its corresponding clock Olivier Langlois
2013-04-10 11:35 ` Peter Zijlstra
2013-04-10 15:48   ` Olivier Langlois
2013-04-12  9:16     ` Peter Zijlstra
2013-04-15  1:55       ` Olivier Langlois
2013-04-12  9:18     ` Peter Zijlstra
2013-04-12 10:50     ` Peter Zijlstra
2013-04-12 15:55       ` Peter Zijlstra
2013-04-15  6:11         ` Olivier Langlois
2013-04-19 13:03         ` Frederic Weisbecker
2013-04-19 17:38           ` KOSAKI Motohiro
2013-04-19 18:08             ` KOSAKI Motohiro
2013-04-26  4:40               ` Olivier Langlois
2013-04-26  6:27                 ` Olivier Langlois
2013-04-26 19:08                   ` KOSAKI Motohiro
2013-04-27  1:51                     ` Olivier Langlois
2013-04-27  2:15                       ` KOSAKI Motohiro
2013-04-27  5:02                         ` Olivier Langlois
2013-04-27  5:17                           ` Olivier Langlois
2013-04-27  5:31                           ` Olivier Langlois
2013-04-27  5:06                         ` Olivier Langlois
2013-04-27  4:40                     ` [PATCH v2 1/3] " Olivier Langlois
2013-04-29  0:45                       ` Frederic Weisbecker
2013-04-29 17:29                         ` Olivier Langlois
2013-04-29  5:06                       ` KOSAKI Motohiro
2013-04-29 17:10                         ` Olivier Langlois
2013-04-29 17:41                           ` Olivier Langlois
2013-04-29 17:56                           ` KOSAKI Motohiro
2013-04-29 18:20                             ` Olivier Langlois
2013-04-29 18:31                               ` KOSAKI Motohiro [this message]
2013-04-29 18:54                                 ` Olivier Langlois
2013-04-29 19:09                                   ` KOSAKI Motohiro
2013-04-29 21:20                                     ` Olivier Langlois
2013-04-29 22:42                                       ` KOSAKI Motohiro
     [not found]                     ` <1367036552.7911.63.camel@Wailaba2>
2013-04-27  4:40                       ` [PATCH v2 2/3] " Olivier Langlois
2013-04-27  4:41                       ` [PATCH v2 3/3] " Olivier Langlois
2013-04-29  6:25                         ` KOSAKI Motohiro
2013-04-29 17:16                           ` Olivier Langlois
2013-04-11  3:29   ` [PATCH] " Olivier Langlois

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=517EBC71.4070709@gmail.com \
    --to=kosaki.motohiro@gmail.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=olivier@trillion01.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=schwidefsky@de.ibm.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox